jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/371284 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0 ...................................................................... build: Updating mediawiki/mediawiki-codesniffer to 0.11.0 Change-Id: I8d9eb6a21cdfb758920425e0e708c297b437b379 --- M composer.json M src/ElectronPdfServiceHooks.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/composer.json b/composer.json index d368985..a4c40a7 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "require-dev": { "jakub-onderka/php-parallel-lint": "0.9.2", - "mediawiki/mediawiki-codesniffer": "0.10.1", + "mediawiki/mediawiki-codesniffer": "0.11.0", "jakub-onderka/php-console-highlighter": "0.3.2" }, "scripts": { diff --git a/src/ElectronPdfServiceHooks.php b/src/ElectronPdfServiceHooks.php index 7af95fd..581090b 100644 --- a/src/ElectronPdfServiceHooks.php +++ b/src/ElectronPdfServiceHooks.php @@ -75,7 +75,7 @@ } private static function getIndexOfDownloadPdfSidebarItem( $portlet, $collectionFormats ) { - $usedPdfLib = array_search( 'PDF', $collectionFormats ); + $usedPdfLib = array_search( 'PDF', $collectionFormats ); if ( $usedPdfLib !== false ) { foreach ( $portlet as $index => $element ) { if ( $element['id'] === 'coll-download-as-' . $usedPdfLib ) { -- To view, visit https://gerrit.wikimedia.org/r/371284 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d9eb6a21cdfb758920425e0e708c297b437b379 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ElectronPdfService Gerrit-Branch: master Gerrit-Owner: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Andrew-WMDE <andrew.kos...@wikimedia.de> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits