jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354561 )
Change subject: Fix positioning of the language change popup when sidebar is on
the right
......................................................................
Fix positioning of the language change popup when sidebar is on the right
This fixes the same issue as 1d395d49660e340df6ecd120b91bbb55947c4419,
but for the little language change popup (shown after you change the
language) instead of the main interface.
Change-Id: I28d3e8baeebf4619f4f810869c8a2a3fb60496d9
---
M resources/js/ext.uls.interface.js
1 file changed, 15 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
TheDJ: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
diff --git a/resources/js/ext.uls.interface.js
b/resources/js/ext.uls.interface.js
index 7fe90f5..2ceba42 100644
--- a/resources/js/ext.uls.interface.js
+++ b/resources/js/ext.uls.interface.js
@@ -181,7 +181,7 @@
* @param {string} previousAutonym
*/
function showUndoTooltip( previousLang, previousAutonym ) {
- var $ulsTrigger, ulsPopup,
+ var $ulsTrigger, ulsPopup, ulsPopupPosition,
ulsPosition = mw.config.get( 'wgULSPosition' );
$ulsTrigger = ( ulsPosition === 'interlanguage' ) ?
@@ -242,13 +242,26 @@
if ( ulsPopup ) {
ulsPopup.$element.remove();
}
+ if ( ulsPosition === 'interlanguage' ) {
+ if ( $ulsTrigger.offset().left > $( window ).width() /
2 ) {
+ ulsPopupPosition = 'before';
+ } else {
+ ulsPopupPosition = 'after';
+ }
+ // Reverse for RTL
+ if ( $( 'html' ).prop( 'dir' ) === 'rtl' ) {
+ ulsPopupPosition = ( ulsPopupPosition ===
'after' ) ? 'before' : 'after';
+ }
+ } else {
+ ulsPopupPosition = 'below';
+ }
ulsPopup = new OO.ui.PopupWidget( {
padded: true,
width: 300,
classes: [ 'uls-tipsy' ],
// Automatically positioned relative to the trigger
$floatableContainer: $ulsTrigger,
- position: ( ulsPosition === 'interlanguage' ) ? 'after'
: 'below',
+ position: ulsPopupPosition,
$content: ( function () {
var link = $( '<a>' ).text( previousAutonym )
.attr( {
--
To view, visit https://gerrit.wikimedia.org/r/354561
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28d3e8baeebf4619f4f810869c8a2a3fb60496d9
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
