Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54021
Change subject: Improve type hints
......................................................................
Improve type hints
Change-Id: I05ba765ca721877292bf2e3125ec8e42a95876ac
---
M DataValues/includes/values/BooleanValue.php
M DataValues/includes/values/GeoCoordinateValue.php
M DataValues/includes/values/IriValue.php
M DataValues/includes/values/MediaWikiTitleValue.php
M DataValues/includes/values/MonolingualTextValue.php
M DataValues/includes/values/MultilingualTextValue.php
M DataValues/includes/values/NumberValue.php
M DataValues/includes/values/PropertyValue.php
M DataValues/includes/values/QuantityValue.php
M DataValues/includes/values/StringValue.php
M DataValues/includes/values/TimeValue.php
M DataValues/includes/values/UnknownValue.php
12 files changed, 28 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues
refs/changes/21/54021/1
diff --git a/DataValues/includes/values/BooleanValue.php
b/DataValues/includes/values/BooleanValue.php
index f01b03b..2fe4dc5 100644
--- a/DataValues/includes/values/BooleanValue.php
+++ b/DataValues/includes/values/BooleanValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -121,7 +122,7 @@
*
* @param mixed $data
*
- * @return DataValue
+ * @return BooleanValue
*/
public static function newFromArray( $data ) {
return new static( $data );
diff --git a/DataValues/includes/values/GeoCoordinateValue.php
b/DataValues/includes/values/GeoCoordinateValue.php
index 0d10a0a..3edf645 100644
--- a/DataValues/includes/values/GeoCoordinateValue.php
+++ b/DataValues/includes/values/GeoCoordinateValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -267,7 +268,7 @@
*
* @param array $data
*
- * @return DataValue
+ * @return GeoCoordinateValue
*/
public static function newFromArray( array $data ) {
return new static( $data['latitude'], $data['longitude'],
$data['altitude'], $data['globe'] );
diff --git a/DataValues/includes/values/IriValue.php
b/DataValues/includes/values/IriValue.php
index 42b2bdb..b3333fe 100644
--- a/DataValues/includes/values/IriValue.php
+++ b/DataValues/includes/values/IriValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -281,7 +282,7 @@
*
* @param array $data
*
- * @return DataValue
+ * @return IriValue
*/
public static function newFromArray( array $data ) {
return new static( $data['scheme'], $data['hierarchicalpart'],
$data['query'], $data['fragment'] );
diff --git a/DataValues/includes/values/MediaWikiTitleValue.php
b/DataValues/includes/values/MediaWikiTitleValue.php
index fa3db92..8494fe9 100644
--- a/DataValues/includes/values/MediaWikiTitleValue.php
+++ b/DataValues/includes/values/MediaWikiTitleValue.php
@@ -1,7 +1,9 @@
<?php
namespace DataValues;
-use InvalidArgumentException, Title;
+
+use InvalidArgumentException;
+use Title;
/**
* Class representing a MediaWiki title value.
@@ -117,7 +119,7 @@
*
* @param mixed $data
*
- * @return DataValue
+ * @return MediaWikiTitleValue
*/
public static function newFromArray( $data ) {
return new static( $data );
diff --git a/DataValues/includes/values/MonolingualTextValue.php
b/DataValues/includes/values/MonolingualTextValue.php
index 36d72c7..621a1d3 100644
--- a/DataValues/includes/values/MonolingualTextValue.php
+++ b/DataValues/includes/values/MonolingualTextValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -178,7 +179,7 @@
*
* @param array $data
*
- * @return DataValue
+ * @return MonolingualTextValue
*/
public static function newFromArray( array $data ) {
return new static( $data['language'], $data['text'] );
diff --git a/DataValues/includes/values/MultilingualTextValue.php
b/DataValues/includes/values/MultilingualTextValue.php
index 81e2d3c..94be497 100644
--- a/DataValues/includes/values/MultilingualTextValue.php
+++ b/DataValues/includes/values/MultilingualTextValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -162,7 +163,7 @@
*
* @param array $data
*
- * @return DataValue
+ * @return MultilingualTextValue
*/
public static function newFromArray( array $data ) {
$values = array();
diff --git a/DataValues/includes/values/NumberValue.php
b/DataValues/includes/values/NumberValue.php
index 815adcb..b640f1b 100644
--- a/DataValues/includes/values/NumberValue.php
+++ b/DataValues/includes/values/NumberValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -124,7 +125,7 @@
*
* @param mixed $data
*
- * @return DataValue
+ * @return NumberValue
*/
public static function newFromArray( $data ) {
return new static( $data );
diff --git a/DataValues/includes/values/PropertyValue.php
b/DataValues/includes/values/PropertyValue.php
index 363466a..3d636d5 100644
--- a/DataValues/includes/values/PropertyValue.php
+++ b/DataValues/includes/values/PropertyValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -142,7 +143,7 @@
*
* @param mixed $data
*
- * @return DataValue
+ * @return PropertyValue
* @throws InvalidArgumentException
*/
public static function newFromArray( $data ) {
diff --git a/DataValues/includes/values/QuantityValue.php
b/DataValues/includes/values/QuantityValue.php
index 0e66abf..86eeeb7 100644
--- a/DataValues/includes/values/QuantityValue.php
+++ b/DataValues/includes/values/QuantityValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -213,7 +214,7 @@
*
* @param array $data
*
- * @return DataValue
+ * @return QuantityValue
*/
public static function newFromArray( array $data ) {
return new static( $data['value'], $data['unit'],
$data['accuracy'] );
diff --git a/DataValues/includes/values/StringValue.php
b/DataValues/includes/values/StringValue.php
index f4251c0..caacbe5 100644
--- a/DataValues/includes/values/StringValue.php
+++ b/DataValues/includes/values/StringValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -121,7 +122,7 @@
*
* @param mixed $data
*
- * @return DataValue
+ * @return StringValue
*/
public static function newFromArray( $data ) {
return new static( $data );
diff --git a/DataValues/includes/values/TimeValue.php
b/DataValues/includes/values/TimeValue.php
index 3b9dad5..5971912 100644
--- a/DataValues/includes/values/TimeValue.php
+++ b/DataValues/includes/values/TimeValue.php
@@ -1,7 +1,9 @@
<?php
namespace DataValues;
-use InvalidArgumentException, OutOfBoundsException;
+
+use InvalidArgumentException;
+use OutOfBoundsException;
/**
* Class representing a time value.
@@ -315,7 +317,7 @@
*
* @param array $data
*
- * @return DataValue
+ * @return TimeValue
*/
public static function newFromArray( array $data ) {
return new static(
diff --git a/DataValues/includes/values/UnknownValue.php
b/DataValues/includes/values/UnknownValue.php
index 69fded3..a4dd3a4 100644
--- a/DataValues/includes/values/UnknownValue.php
+++ b/DataValues/includes/values/UnknownValue.php
@@ -1,6 +1,7 @@
<?php
namespace DataValues;
+
use InvalidArgumentException;
/**
@@ -132,7 +133,7 @@
*
* @param mixed $data
*
- * @return DataValue
+ * @return UnknownValue
*/
public static function newFromArray( $data ) {
return new static( $data );
--
To view, visit https://gerrit.wikimedia.org/r/54021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05ba765ca721877292bf2e3125ec8e42a95876ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
