Smalyshev has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371470 )
Change subject: Temporarily disable highlighting parse errors
......................................................................
Temporarily disable highlighting parse errors
Upstream parser does not recognize WITH/INCLUDE syntax. Until
this is fixed, do not highlight errors produced by the parser.
Bug: T171935
Change-Id: Id3308044de999475c6f8ac0f8d9017bd636ad30b
---
M wikibase/queryService/ui/App.js
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/70/371470/1
diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index fbf4796..1867d68 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -258,8 +258,9 @@
$( '.query-helper' ).css( 'min-width', '' );
this._updateQueryHelperMinWidth(); // TODO also do this
after labels in the query helper have loaded
} catch ( e ) {
-
- this._editor.highlightError( e.message );
+ // Temporarily disabled due to T171935
+ // TODO: Re-enable when handling of WITH is fixed
+ // this._editor.highlightError( e.message );
window.console.error( e );
}
};
--
To view, visit https://gerrit.wikimedia.org/r/371470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3308044de999475c6f8ac0f8d9017bd636ad30b
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Smalyshev <smalys...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
