Yaron Koren has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371465 )

Change subject: Partial undo of 5cae0c8730c2
......................................................................


Partial undo of 5cae0c8730c2

It caused #autoedit to erase the fields that it didn't modify.

Change-Id: I2687321da01d94844cec005a5a63971f1419df5a
---
M includes/PF_AutoeditAPI.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/PF_AutoeditAPI.php b/includes/PF_AutoeditAPI.php
index 08bd65c..a43b96a 100644
--- a/includes/PF_AutoeditAPI.php
+++ b/includes/PF_AutoeditAPI.php
@@ -929,7 +929,7 @@
 
                // Get wikitext for submitted data and form - call formHTML(),
                // if we haven't called it already.
-               if ( !$formHtmlHasRun ) {
+               if ( $preloadContent == '' ) {
                        list ( $formHTML, $targetContent, $generatedFormName, 
$generatedTargetNameFormula ) =
                                $wgPageFormsFormPrinter->formHTML( 
$formContent, $isFormSubmitted, $pageExists, $formArticleId, $preloadContent, 
$targetName, $targetNameFormula );
                } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/371465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2687321da01d94844cec005a5a63971f1419df5a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to