jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/370596 )
Change subject: Fix E_NOTICE in CommentsOfTheDay.class.php
......................................................................
Fix E_NOTICE in CommentsOfTheDay.class.php
Notice: Undefined index: nocache in
../extensions/Comments/includes/CommentsOfTheDay.class.php on line 30
Change-Id: Ib4c52ce62b9c824bae2be7df78c5315fe7bf05a6
---
M includes/CommentsOfTheDay.class.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/CommentsOfTheDay.class.php
b/includes/CommentsOfTheDay.class.php
index 4f89d34..eeb86b1 100644
--- a/includes/CommentsOfTheDay.class.php
+++ b/includes/CommentsOfTheDay.class.php
@@ -5,7 +5,6 @@
*
* @file
* @ingroup Extensions
- * @date 27 November 2015
*/
class CommentsOfTheDay {
@@ -27,7 +26,8 @@
* @return string HTML
*/
public static function getHTML( $input, $args, $parser ) {
- $comments = self::get( (bool)$args['nocache'] );
+ $skipCache = isset( $args['nocache'] ) && $args['nocache'];
+ $comments = self::get( $skipCache );
$commentOutput = '';
foreach ( $comments as $comment ) {
--
To view, visit https://gerrit.wikimedia.org/r/370596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4c52ce62b9c824bae2be7df78c5315fe7bf05a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Comments
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: UltrasonicNXT <adamr_car...@btinternet.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
