Fz-29 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371512 )
Change subject: Fix : No comma escaping for hierarchy structure
......................................................................
Fix : No comma escaping for hierarchy structure
Change-Id: I94210eddb59de4a4da80fae5a2e8eaad3fb889eb
---
M CargoFieldDescription.php
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo
refs/changes/12/371512/1
diff --git a/CargoFieldDescription.php b/CargoFieldDescription.php
index 8c22c58..6c78859 100644
--- a/CargoFieldDescription.php
+++ b/CargoFieldDescription.php
@@ -80,11 +80,11 @@
// Remove
prefix of multiple "*"
$allowedValuesArray[] = preg_replace( '/^[*]*/', '', $node );
}
- $paramValue = implode(
',', $allowedValuesArray );
+ } else {
+ $delimiter = ',';
+ $allowedValuesStr =
str_replace( "\\$delimiter", "\a", $paramValue );
+ $allowedValuesArray =
explode( $delimiter, $allowedValuesStr );
}
- $delimiter = ',';
- $allowedValuesStr =
str_replace( "\\$delimiter", "\a", $paramValue );
- $allowedValuesArray = explode(
$delimiter, $allowedValuesStr );
foreach ( $allowedValuesArray
as $i => $value ) {
if ( $value == '' )
continue;
// Replace beep back
with delimiter, trim.
--
To view, visit https://gerrit.wikimedia.org/r/371512
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94210eddb59de4a4da80fae5a2e8eaad3fb889eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Fz-29 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
