jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371495 )

Change subject: Use correct variable name in @param documentation
......................................................................


Use correct variable name in @param documentation

For some varargs a variable name is added with suffix ,... as seen for
many other varargs

Some @param are swapped, because there are in the wrong order

Enable Sniff MediaWiki.Commenting.FunctionComment.ParamNameNoMatch

Change-Id: I60fec6025bce824d5c67563ab7b65ad6cd628ad8
---
M includes/FauxRequest.php
M includes/GlobalFunctions.php
M includes/Message.php
M includes/OutputPage.php
M includes/api/ApiAuthManagerHelper.php
M includes/api/ApiBase.php
M includes/api/ApiMain.php
M includes/api/SearchApi.php
M includes/collation/CustomUppercaseCollation.php
M includes/context/ContextSource.php
M includes/context/RequestContext.php
M includes/htmlform/HTMLForm.php
M includes/libs/MemoizedCallable.php
M includes/libs/MultiHttpClient.php
M includes/libs/filebackend/FileBackend.php
M includes/libs/objectcache/BagOStuff.php
M includes/libs/objectcache/MultiWriteBagOStuff.php
M includes/libs/objectcache/WANObjectCache.php
M includes/libs/rdbms/database/Database.php
M includes/libs/rdbms/lbfactory/ILBFactory.php
M includes/logging/LogEventsList.php
M includes/mail/UserMailer.php
M includes/media/WebP.php
M includes/parser/ParserOptions.php
M includes/resourceloader/ResourceLoader.php
M includes/resourceloader/ResourceLoaderContext.php
M includes/revisiondelete/RevDelList.php
M includes/search/SearchExactMatchRescorer.php
M includes/search/SearchSuggestion.php
M includes/session/PHPSessionHandler.php
M includes/session/SessionProvider.php
M includes/skins/BaseTemplate.php
M includes/specials/SpecialFilepath.php
M includes/specials/SpecialMediaStatistics.php
M includes/user/User.php
M includes/utils/AutoloadGenerator.php
M phpcs.xml
M tests/parser/ParserTestRunner.php
M tests/phpunit/includes/auth/LegacyHookPreAuthenticationProviderTest.php
39 files changed, 45 insertions(+), 45 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve



diff --git a/includes/FauxRequest.php b/includes/FauxRequest.php
index 3b2283b..9147240 100644
--- a/includes/FauxRequest.php
+++ b/includes/FauxRequest.php
@@ -126,7 +126,7 @@
 
        /**
         * @since 1.26
-        * @param string $name Unprefixed name of the cookie to set
+        * @param string $key Unprefixed name of the cookie to set
         * @param string|null $value Value of the cookie to set
         * @param string|null $prefix Cookie prefix. Defaults to $wgCookiePrefix
         */
diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index b35a1f0..49159ed 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -2234,7 +2234,8 @@
  * (https://bugs.php.net/bug.php?id=26285) and the locale problems on Linux in
  * PHP 5.2.6+ (bug backported to earlier distro releases of PHP).
  *
- * @param string ... strings to escape and glue together, or a single array of 
strings parameter
+ * @param string $args,... strings to escape and glue together,
+ *  or a single array of strings parameter
  * @return string
  */
 function wfEscapeShellArg( /*...*/ ) {
diff --git a/includes/Message.php b/includes/Message.php
index be6b0af..8777c6f 100644
--- a/includes/Message.php
+++ b/includes/Message.php
@@ -488,7 +488,7 @@
         *
         * @since 1.17
         *
-        * @param mixed ... Parameters as strings or arrays from
+        * @param mixed $args,... Parameters as strings or arrays from
         *  Message::numParam() and the like, or a single array of parameters.
         *
         * @return Message $this
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 57cb194..8f62a85 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -688,7 +688,7 @@
         * Add one or more head items to the output
         *
         * @since 1.28
-        * @param string|string[] $value Raw HTML
+        * @param string|string[] $values Raw HTML
         */
        public function addHeadItems( $values ) {
                $this->mHeadItems = array_merge( $this->mHeadItems, 
(array)$values );
@@ -3797,7 +3797,7 @@
         * Caller is responsible for ensuring the file exists. Emits a PHP 
warning otherwise.
         *
         * @since 1.27
-        * @param string $remotePath URL path prefix that points to $localPath
+        * @param string $remotePathPrefix URL path prefix that points to 
$localPath
         * @param string $localPath File directory exposed at $remotePath
         * @param string $file Path to target file relative to $localPath
         * @return string URL
diff --git a/includes/api/ApiAuthManagerHelper.php 
b/includes/api/ApiAuthManagerHelper.php
index 3a9fb73..d6b9f76 100644
--- a/includes/api/ApiAuthManagerHelper.php
+++ b/includes/api/ApiAuthManagerHelper.php
@@ -229,8 +229,8 @@
 
        /**
         * Logs successful or failed authentication.
-        * @param string|AuthenticationResponse $result Response or error 
message
         * @param string $event Event type (e.g. 'accountcreation')
+        * @param string|AuthenticationResponse $result Response or error 
message
         */
        public function logAuthenticationResult( $event, $result ) {
                if ( is_string( $result ) ) {
@@ -345,7 +345,7 @@
        /**
         * Fetch the standard parameters this helper recognizes
         * @param string $action AuthManager action
-        * @param string $param... Parameters to use
+        * @param string $param,... Parameters to use
         * @return array
         */
        public static function getStandardParams( $action, $param /* ... */ ) {
diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index 81696e0..2012e7d 100644
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -668,7 +668,7 @@
 
        /**
         * Set the continuation manager
-        * @param ApiContinuationManager|null
+        * @param ApiContinuationManager|null $manager
         */
        public function setContinuationManager( $manager ) {
                // Main module has setContinuationManager() method overridden
diff --git a/includes/api/ApiMain.php b/includes/api/ApiMain.php
index 6468235..f6dd524 100644
--- a/includes/api/ApiMain.php
+++ b/includes/api/ApiMain.php
@@ -370,7 +370,7 @@
 
        /**
         * Set the continuation manager
-        * @param ApiContinuationManager|null
+        * @param ApiContinuationManager|null $manager
         */
        public function setContinuationManager( $manager ) {
                if ( $manager !== null ) {
diff --git a/includes/api/SearchApi.php b/includes/api/SearchApi.php
index fb9c4e6..552292b 100644
--- a/includes/api/SearchApi.php
+++ b/includes/api/SearchApi.php
@@ -144,7 +144,7 @@
         *    one ( to support the continue parameter )
         *  - namespace: mandatory
         *  - search engine profiles defined by 
SearchApi::getSearchProfileParams()
-        * @param string[]|null API request params (must be sanitized by
+        * @param string[]|null $params API request params (must be sanitized by
         * ApiBase::extractRequestParams() before)
         * @return SearchEngine the search engine
         */
diff --git a/includes/collation/CustomUppercaseCollation.php 
b/includes/collation/CustomUppercaseCollation.php
index 1b96bff..301972d 100644
--- a/includes/collation/CustomUppercaseCollation.php
+++ b/includes/collation/CustomUppercaseCollation.php
@@ -48,7 +48,7 @@
         * @note This assumes $alphabet does not contain U+F3000-U+F303F
         *
         * @param array $alphabet Sorted array of uppercase characters.
-        * @param Language $language What language for number sorting.
+        * @param Language $lang What language for number sorting.
         */
        public function __construct( array $alphabet, Language $lang ) {
                // It'd be trivial to extend this past 64, you'd just
diff --git a/includes/context/ContextSource.php 
b/includes/context/ContextSource.php
index 434201a..cea8460 100644
--- a/includes/context/ContextSource.php
+++ b/includes/context/ContextSource.php
@@ -183,7 +183,7 @@
         * @since 1.18
         * @param string|string[]|MessageSpecifier $key Message key, or array 
of keys,
         *   or a MessageSpecifier.
-        * @param mixed ...
+        * @param mixed $args,...
         * @return Message
         */
        public function msg( $key /* $args */ ) {
diff --git a/includes/context/RequestContext.php 
b/includes/context/RequestContext.php
index 2ac4192..4a772ee 100644
--- a/includes/context/RequestContext.php
+++ b/includes/context/RequestContext.php
@@ -451,7 +451,7 @@
         *
         * @param string|string[]|MessageSpecifier $key Message key, or array 
of keys,
         *   or a MessageSpecifier.
-        * @param mixed ...
+        * @param mixed $args,...
         * @return Message
         */
        public function msg( $key ) {
diff --git a/includes/htmlform/HTMLForm.php b/includes/htmlform/HTMLForm.php
index dda9e88..7293b99 100644
--- a/includes/htmlform/HTMLForm.php
+++ b/includes/htmlform/HTMLForm.php
@@ -271,7 +271,7 @@
         * Construct a HTMLForm object for given display type. May return a 
HTMLForm subclass.
         *
         * @param string $displayFormat
-        * @param mixed $arguments... Additional arguments to pass to the 
constructor.
+        * @param mixed $arguments,... Additional arguments to pass to the 
constructor.
         * @return HTMLForm
         */
        public static function factory( $displayFormat/*, $arguments...*/ ) {
diff --git a/includes/libs/MemoizedCallable.php 
b/includes/libs/MemoizedCallable.php
index 01adeab..90c7a64 100644
--- a/includes/libs/MemoizedCallable.php
+++ b/includes/libs/MemoizedCallable.php
@@ -134,7 +134,7 @@
         *
         * Like MemoizedCallable::invokeArgs(), but variadic.
         *
-        * @param mixed ...$params Parameters for memoized function or method.
+        * @param mixed $params,... Parameters for memoized function or method.
         * @return mixed The memoized callable's return value.
         */
        public function invoke() {
diff --git a/includes/libs/MultiHttpClient.php 
b/includes/libs/MultiHttpClient.php
index 4f6195c..6c48cee 100644
--- a/includes/libs/MultiHttpClient.php
+++ b/includes/libs/MultiHttpClient.php
@@ -435,7 +435,7 @@
        /**
         * Register a logger
         *
-        * @param LoggerInterface
+        * @param LoggerInterface $logger
         */
        public function setLogger( LoggerInterface $logger ) {
                $this->logger = $logger;
diff --git a/includes/libs/filebackend/FileBackend.php 
b/includes/libs/filebackend/FileBackend.php
index 6f51081..51308c1 100644
--- a/includes/libs/filebackend/FileBackend.php
+++ b/includes/libs/filebackend/FileBackend.php
@@ -1591,7 +1591,7 @@
         *   - StatusValue::newGood() if this method is called without 
parameters
         *   - StatusValue::newFatal() with all parameters to this method if 
passed in
         *
-        * @param ... string
+        * @param string $args,...
         * @return StatusValue
         */
        final protected function newStatus() {
diff --git a/includes/libs/objectcache/BagOStuff.php 
b/includes/libs/objectcache/BagOStuff.php
index e0f2750..a262e0e 100644
--- a/includes/libs/objectcache/BagOStuff.php
+++ b/includes/libs/objectcache/BagOStuff.php
@@ -747,7 +747,7 @@
         * Make a global cache key.
         *
         * @since 1.27
-        * @param string ... Key component (variadic)
+        * @param string $keys,... Key component
         * @return string
         */
        public function makeGlobalKey() {
@@ -758,7 +758,7 @@
         * Make a cache key, scoped to this instance's keyspace.
         *
         * @since 1.27
-        * @param string ... Key component (variadic)
+        * @param string $keys,... Key component
         * @return string
         */
        public function makeKey() {
diff --git a/includes/libs/objectcache/MultiWriteBagOStuff.php 
b/includes/libs/objectcache/MultiWriteBagOStuff.php
index d94578d..65f3a8af 100644
--- a/includes/libs/objectcache/MultiWriteBagOStuff.php
+++ b/includes/libs/objectcache/MultiWriteBagOStuff.php
@@ -174,7 +174,7 @@
         * @param integer $count
         * @param bool $asyncWrites
         * @param string $method
-        * @param mixed ...
+        * @param mixed $args,...
         * @return bool
         */
        protected function doWrite( $count, $asyncWrites, $method /*, ... */ ) {
diff --git a/includes/libs/objectcache/WANObjectCache.php 
b/includes/libs/objectcache/WANObjectCache.php
index 4f90c7d..a80ed8d 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -1315,7 +1315,7 @@
 
        /**
         * @see BagOStuff::makeKey()
-        * @param string ... Key component
+        * @param string $keys,... Key component
         * @return string
         * @since 1.27
         */
@@ -1325,7 +1325,7 @@
 
        /**
         * @see BagOStuff::makeGlobalKey()
-        * @param string ... Key component
+        * @param string $keys,... Key component
         * @return string
         * @since 1.27
         */
diff --git a/includes/libs/rdbms/database/Database.php 
b/includes/libs/rdbms/database/Database.php
index b8b44e6..0726b5a 100644
--- a/includes/libs/rdbms/database/Database.php
+++ b/includes/libs/rdbms/database/Database.php
@@ -3190,7 +3190,7 @@
         * @see WANObjectCache::getWithSetCallback()
         *
         * @param IDatabase $db1
-        * @param IDatabase ...
+        * @param IDatabase $dbs,...
         * @return array Map of values:
         *   - lag: highest lag of any of the DBs or false on error (e.g. 
replication stopped)
         *   - since: oldest UNIX timestamp of any of the DB lag estimates
diff --git a/includes/libs/rdbms/lbfactory/ILBFactory.php 
b/includes/libs/rdbms/lbfactory/ILBFactory.php
index 6e328f4..117df68 100644
--- a/includes/libs/rdbms/lbfactory/ILBFactory.php
+++ b/includes/libs/rdbms/lbfactory/ILBFactory.php
@@ -40,7 +40,7 @@
         *
         * Sub-classes will extend the required keys in $conf with additional 
parameters
         *
-        * @param $conf $params Array with keys:
+        * @param array $conf Array with keys:
         *  - localDomain: A DatabaseDomain or domain ID string.
         *  - readOnlyReason : Reason the master DB is read-only if so 
[optional]
         *  - srvCache : BagOStuff object for server cache [optional]
diff --git a/includes/logging/LogEventsList.php 
b/includes/logging/LogEventsList.php
index 2b09cca..00d3bd3 100644
--- a/includes/logging/LogEventsList.php
+++ b/includes/logging/LogEventsList.php
@@ -60,7 +60,7 @@
         *
         * @param IContextSource|Skin $context Context to use; formerly it was
         *   a Skin object. Use of Skin is deprecated.
-        * @param LinkRenderer|null $linkRenderer, previously unused
+        * @param LinkRenderer|null $linkRenderer previously unused
         * @param int $flags Can be a combination of self::NO_ACTION_LINK,
         *   self::NO_EXTRA_USER_LINKS or self::USE_CHECKBOXES.
         */
diff --git a/includes/mail/UserMailer.php b/includes/mail/UserMailer.php
index 1f8489f..cb07fd5 100644
--- a/includes/mail/UserMailer.php
+++ b/includes/mail/UserMailer.php
@@ -102,7 +102,7 @@
         * @param MailAddress $from Sender's email
         * @param string $subject Email's subject.
         * @param string $body Email's text or Array of two strings to be the 
text and html bodies
-        * @param array $options:
+        * @param array $options Keys:
         *     'replyTo' MailAddress
         *     'contentType' string default 'text/plain; charset=UTF-8'
         *     'headers' array Extra headers to set
@@ -196,7 +196,7 @@
         * @param MailAddress $from Sender's email
         * @param string $subject Email's subject.
         * @param string $body Email's text or Array of two strings to be the 
text and html bodies
-        * @param array $options:
+        * @param array $options Keys:
         *     'replyTo' MailAddress
         *     'contentType' string default 'text/plain; charset=UTF-8'
         *     'headers' array Extra headers to set
diff --git a/includes/media/WebP.php b/includes/media/WebP.php
index e2c2d2d..4555c19 100644
--- a/includes/media/WebP.php
+++ b/includes/media/WebP.php
@@ -86,7 +86,7 @@
        /**
         * Extracts the image size and WebP type from a file
         *
-        * @param string $chunks Chunks as extracted by RiffExtractor
+        * @param string $filename
         * @return array|bool Header data array with entries 'compression', 
'width' and 'height',
         * where 'compression' can be 'lossy', 'lossless', 'animated' or 
'unknown'. False if
         * file is not a valid WebP file.
diff --git a/includes/parser/ParserOptions.php 
b/includes/parser/ParserOptions.php
index 73a9927..5e2845f 100644
--- a/includes/parser/ParserOptions.php
+++ b/includes/parser/ParserOptions.php
@@ -761,7 +761,7 @@
         * is it allowed in the specific case of parsing this page.
         * @see self::getAllowUnsafeRawHtml()
         * @since 1.29
-        * @param bool|null Value to set or null to get current value
+        * @param bool|null $x Value to set or null to get current value
         * @return bool Current value for allowUnsafeRawHtml
         */
        public function setAllowUnsafeRawHtml( $x ) {
diff --git a/includes/resourceloader/ResourceLoader.php 
b/includes/resourceloader/ResourceLoader.php
index ad16420..c58bb00 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -655,7 +655,7 @@
         *
         * @since 1.26
         * @param ResourceLoaderContext $context
-        * @param string[] $modules List of known module names
+        * @param string[] $moduleNames List of known module names
         * @return string Hash
         */
        public function getCombinedVersion( ResourceLoaderContext $context, 
array $moduleNames ) {
diff --git a/includes/resourceloader/ResourceLoaderContext.php 
b/includes/resourceloader/ResourceLoaderContext.php
index f99114e..cbb0bec 100644
--- a/includes/resourceloader/ResourceLoaderContext.php
+++ b/includes/resourceloader/ResourceLoaderContext.php
@@ -224,7 +224,7 @@
         * @since 1.27
         * @param string|string[]|MessageSpecifier $key Message key, or array 
of keys,
         *   or a MessageSpecifier.
-        * @param mixed ...
+        * @param mixed $args,...
         * @return Message
         */
        public function msg( $key ) {
diff --git a/includes/revisiondelete/RevDelList.php 
b/includes/revisiondelete/RevDelList.php
index 64a6aec..a2c58e6 100644
--- a/includes/revisiondelete/RevDelList.php
+++ b/includes/revisiondelete/RevDelList.php
@@ -402,7 +402,7 @@
        /**
         * A hook for setVisibility(): do any necessary updates post-commit.
         * STUB
-        * @param array [id => ['oldBits' => $oldBits, 'newBits' => $newBits], 
... ]
+        * @param array $visibilityChangeMap [id => ['oldBits' => $oldBits, 
'newBits' => $newBits], ... ]
         * @return Status
         */
        public function doPostCommitUpdates( array $visibilityChangeMap ) {
diff --git a/includes/search/SearchExactMatchRescorer.php 
b/includes/search/SearchExactMatchRescorer.php
index 40cfe39..0e99ba9 100644
--- a/includes/search/SearchExactMatchRescorer.php
+++ b/includes/search/SearchExactMatchRescorer.php
@@ -35,8 +35,8 @@
         * to not be in the results or be lower down the list.
         * @param string $search the query
         * @param int[] $namespaces the namespaces
-        * @param int $limit the max number of results to return
         * @param string[] $srchres results
+        * @param int $limit the max number of results to return
         * @return string[] munged results
         */
        public function rescore( $search, $namespaces, $srchres, $limit ) {
diff --git a/includes/search/SearchSuggestion.php 
b/includes/search/SearchSuggestion.php
index 4e7c782..7f433db 100644
--- a/includes/search/SearchSuggestion.php
+++ b/includes/search/SearchSuggestion.php
@@ -53,7 +53,7 @@
        /**
         * Construct a new suggestion
         * @param float $score the suggestion score
-        * @param string $text|null the suggestion text
+        * @param string|null $text the suggestion text
         * @param Title|null $suggestedTitle the suggested title
         * @param int|null $suggestedTitleID the suggested title ID
         */
diff --git a/includes/session/PHPSessionHandler.php 
b/includes/session/PHPSessionHandler.php
index 084ac05..b76f0ff 100644
--- a/includes/session/PHPSessionHandler.php
+++ b/includes/session/PHPSessionHandler.php
@@ -145,7 +145,7 @@
         * @private Use self::install().
         * @param SessionManager $manager
         * @param BagOStuff $store
-        * @param LoggerInterface $store
+        * @param LoggerInterface $logger
         */
        public function setManager(
                SessionManager $manager, BagOStuff $store, LoggerInterface 
$logger
diff --git a/includes/session/SessionProvider.php 
b/includes/session/SessionProvider.php
index 3cf69b7..ba075e0 100644
--- a/includes/session/SessionProvider.php
+++ b/includes/session/SessionProvider.php
@@ -387,7 +387,7 @@
         * reset whatever token it does use here.
         *
         * @protected For use by \MediaWiki\Session\SessionManager only
-        * @param User $user;
+        * @param User $user
         */
        public function invalidateSessionsForUser( User $user ) {
        }
diff --git a/includes/skins/BaseTemplate.php b/includes/skins/BaseTemplate.php
index aad676f..55f7a67 100644
--- a/includes/skins/BaseTemplate.php
+++ b/includes/skins/BaseTemplate.php
@@ -29,7 +29,7 @@
         * Get a Message object with its context set
         *
         * @param string $name Message name
-        * @param ... $params Message params
+        * @param mixed $params,... Message params
         * @return Message
         */
        public function getMsg( $name /* ... */ ) {
diff --git a/includes/specials/SpecialFilepath.php 
b/includes/specials/SpecialFilepath.php
index 49caaa3..c18faa1 100644
--- a/includes/specials/SpecialFilepath.php
+++ b/includes/specials/SpecialFilepath.php
@@ -35,7 +35,7 @@
        /**
         * Implement by redirecting through Special:Redirect/file.
         *
-        * @param string|null $subpage
+        * @param string|null $par
         * @return Title
         */
        public function getRedirect( $par ) {
diff --git a/includes/specials/SpecialMediaStatistics.php 
b/includes/specials/SpecialMediaStatistics.php
index 44e0db8..83efbcb 100644
--- a/includes/specials/SpecialMediaStatistics.php
+++ b/includes/specials/SpecialMediaStatistics.php
@@ -169,7 +169,7 @@
         *
         * @param string $mime mime type (e.g. image/jpeg)
         * @param int $count Number of images of this type
-        * @param int $totalBytes Total space for images of this type
+        * @param int $bytes Total space for images of this type
         */
        protected function outputTableRow( $mime, $count, $bytes ) {
                $mimeSearch = SpecialPage::getTitleFor( 'MIMEsearch', $mime );
diff --git a/includes/user/User.php b/includes/user/User.php
index d6b63a8..71a4272 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -3519,7 +3519,7 @@
        /**
         * Check if user is allowed to access a feature / make an action
         *
-        * @param string ... Permissions to test
+        * @param string $permissions,... Permissions to test
         * @return bool True if user is allowed to perform *any* of the given 
actions
         */
        public function isAllowedAny() {
@@ -3534,7 +3534,7 @@
 
        /**
         *
-        * @param string ... Permissions to test
+        * @param string $permissions,... Permissions to test
         * @return bool True if the user is allowed to perform *all* of the 
given actions
         */
        public function isAllowedAll() {
diff --git a/includes/utils/AutoloadGenerator.php 
b/includes/utils/AutoloadGenerator.php
index 8931e3c..19f5100 100644
--- a/includes/utils/AutoloadGenerator.php
+++ b/includes/utils/AutoloadGenerator.php
@@ -372,7 +372,7 @@
        /**
         * Accepts the next token in an expect sequence
         *
-        * @param array
+        * @param array $token
         */
        protected function tryEndExpect( $token ) {
                switch ( $this->startToken[0] ) {
diff --git a/phpcs.xml b/phpcs.xml
index 3ea3048..b1ad8d2 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -10,7 +10,6 @@
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.Missing.Protected" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.Missing.Public" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.SpacingAfter" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.SpacingAfterParamName" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.SpacingAfterParamType" />
diff --git a/tests/parser/ParserTestRunner.php 
b/tests/parser/ParserTestRunner.php
index e578418..f694f39 100644
--- a/tests/parser/ParserTestRunner.php
+++ b/tests/parser/ParserTestRunner.php
@@ -477,7 +477,7 @@
         * @see staticSetup
         *
         * @param array $teardown The snippet array
-        * @param ScopedCallback|null A ScopedCallback to consume
+        * @param ScopedCallback|null $nextTeardown A ScopedCallback to consume
         * @return ScopedCallback
         */
        protected function createTeardownObject( $teardown, $nextTeardown = 
null ) {
diff --git 
a/tests/phpunit/includes/auth/LegacyHookPreAuthenticationProviderTest.php 
b/tests/phpunit/includes/auth/LegacyHookPreAuthenticationProviderTest.php
index 3b00194..a4b980f 100644
--- a/tests/phpunit/includes/auth/LegacyHookPreAuthenticationProviderTest.php
+++ b/tests/phpunit/includes/auth/LegacyHookPreAuthenticationProviderTest.php
@@ -282,7 +282,7 @@
         * @dataProvider provideTestForAccountCreation
         * @param string $msg
         * @param Status|null $status
-        * @param StatusValue Result
+        * @param StatusValue $result Result
         */
        public function testTestForAccountCreation( $msg, $status, $result ) {
                $this->hook( 'AbortNewAccount', $this->once() )

-- 
To view, visit https://gerrit.wikimedia.org/r/371495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60fec6025bce824d5c67563ab7b65ad6cd628ad8
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: DCausse <dcau...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to