MaxSem has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371595 )
Change subject: Remove MagicWord::replaceMultiple()
......................................................................
Remove MagicWord::replaceMultiple()
wfDeprecated since 1.25, not used anywhere.
Change-Id: I09fd362a3d795328ffc12572025702ef9b951378
---
M RELEASE-NOTES-1.30
M includes/MagicWord.php
2 files changed, 1 insertion(+), 27 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/95/371595/1
diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index 452cb35..3045c4d 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -158,6 +158,7 @@
nothing and is deprecated.
* mw.util.escapeId() was deprecated, use escapeIdForAttribute() or
escapeIdForLink().
+* MagicWord::replaceMultiple() was removed.
== Compatibility ==
MediaWiki 1.30 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/includes/MagicWord.php b/includes/MagicWord.php
index e70b8ce..6e7799a 100644
--- a/includes/MagicWord.php
+++ b/includes/MagicWord.php
@@ -647,33 +647,6 @@
}
/**
- * $magicarr is an associative array of (magic word ID => replacement)
- * This method uses the php feature to do several replacements at the
same time,
- * thereby gaining some efficiency. The result is placed in the out
variable
- * $result. The return value is true if something was replaced.
- * @deprecated since 1.25, unused
- *
- * @param array $magicarr
- * @param string $subject
- * @param string &$result
- *
- * @return bool
- */
- public function replaceMultiple( $magicarr, $subject, &$result ) {
- wfDeprecated( __METHOD__, '1.25' );
- $search = [];
- $replace = [];
- foreach ( $magicarr as $id => $replacement ) {
- $mw = self::get( $id );
- $search[] = $mw->getRegex();
- $replace[] = $replacement;
- }
-
- $result = preg_replace( $search, $replace, $subject );
- return $result !== $subject;
- }
-
- /**
* Adds all the synonyms of this MagicWord to an array, to allow quick
* lookup in a list of magic words
*
--
To view, visit https://gerrit.wikimedia.org/r/371595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09fd362a3d795328ffc12572025702ef9b951378
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
