jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/370817 )
Change subject: Separate different parts of the message with a new line
......................................................................
Separate different parts of the message with a new line
It's better to separate the different parts of the message
with a new line than a space as it could improve improve it's
readability.
Change-Id: I0d8735d0555c89844ae7c012b3b4494304b183ac
---
M app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Rho: Looks good to me, approved
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
Mholloway: Looks good to me, but someone else must approve
diff --git
a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
index 692f8f8..0c7a540 100644
--- a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
+++ b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
@@ -61,7 +61,7 @@
// message and subtitle in the full page view. Figure out a good way
to handle this.
if (errorType == LinkPreviewErrorType.OFFLINE) {
String message =
getResources().getString(R.string.page_offline_notice_cannot_load_while_offline)
- + " " +
getResources().getString(R.string.page_offline_notice_add_to_reading_list);
+ + "\n" +
getResources().getString(R.string.page_offline_notice_add_to_reading_list);
textView.setText(message);
} else {
textView.setText(getContext().getResources().getString(errorType.text()));
--
To view, visit https://gerrit.wikimedia.org/r/370817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d8735d0555c89844ae7c012b3b4494304b183ac
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Kaartic <kaarticsivaraam91...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Rho <r...@wikimedia.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
