Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371624 )

Change subject: build: Resolve suppressed eslint warnings
......................................................................

build: Resolve suppressed eslint warnings

* Consistent string quoting style.
* Consistent spacing.
* Remove unused variables.

Change-Id: I6f78f1127c563ae3f81b6268eb896b2441ffd840
---
M .eslintrc.json
M resources/mobile.js
2 files changed, 10 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless 
refs/changes/24/371624/1

diff --git a/.eslintrc.json b/.eslintrc.json
index a7d2ee6..9fad52a 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -3,10 +3,5 @@
        "env": {
                "browser": true,
                "jquery": true
-       },
-       "rules": {
-               "no-unused-vars": 0,
-               "quotes": 0,
-               "space-before-function-paren": 0
        }
 }
diff --git a/resources/mobile.js b/resources/mobile.js
index 2166c3c..1ded493 100644
--- a/resources/mobile.js
+++ b/resources/mobile.js
@@ -1,39 +1,39 @@
 /* Popout menus (header) */
 
-$( function() {
+$( function () {
        var toggleTime = 200;
 
        // Open the various menus
-       $( '#user-tools h2' ).on( 'click', function( e ) {
+       $( '#user-tools h2' ).on( 'click', function () {
                if ( $( window ).width() < 851 ) {
                        $( '#personal-inner, #menus-cover' ).fadeToggle( 
toggleTime );
                }
        } );
-       $( '#site-navigation h2' ).on( 'click', function( e ) {
+       $( '#site-navigation h2' ).on( 'click', function () {
                if ( $( window ).width() < 851 ) {
                        $( '#site-navigation .sidebar-inner, #menus-cover' 
).fadeToggle( toggleTime );
                }
        } );
-       $( '#site-tools h2' ).on( 'click', function( e ) {
+       $( '#site-tools h2' ).on( 'click', function () {
                if ( $( window ).width() < 851 ) {
                        $( '#site-tools .sidebar-inner, #menus-cover' 
).fadeToggle( toggleTime );
                }
        } );
-       $( '#ca-more' ).on( 'click', function( e ) {
-               $( '#page-tools .sidebar-inner' ).css( "top", $( '#ca-more' 
).offset().top + 25 );
+       $( '#ca-more' ).on( 'click', function () {
+               $( '#page-tools .sidebar-inner' ).css( 'top', $( '#ca-more' 
).offset().top + 25 );
                if ( $( window ).width() < 851 ) {
                        $( '#page-tools .sidebar-inner, #menus-cover' 
).fadeToggle( toggleTime );
                }
        } );
-       $( '#ca-languages' ).on( 'click', function( e ) {
-               $( '#other-languages .sidebar-inner' ).css( "top", $( 
'#ca-languages' ).offset().top + 25 );
+       $( '#ca-languages' ).on( 'click', function () {
+               $( '#other-languages .sidebar-inner' ).css( 'top', $( 
'#ca-languages' ).offset().top + 25 );
                if ( $( window ).width() < 851 ) {
                        $( '#other-languages .sidebar-inner, #menus-cover' 
).fadeToggle( toggleTime );
                }
        } );
 
        // Close menus on click outside
-       $( document ).click( function( e ) {
+       $( document ).click( function ( e ) {
                if ( $( e.target ).closest( '#menus-cover' ).length > 0 ) {
                        $( '#personal-inner' ).fadeOut( toggleTime );
                        $( '.sidebar-inner' ).fadeOut( toggleTime );
@@ -42,7 +42,7 @@
        } );
 
        // Include alternative closing method for ios
-       $( window ).on( 'swiperight', function( e ) {
+       $( window ).on( 'swiperight', function () {
                if ( $( window ).width() < 851 ) {
                        $( '#personal-inner' ).fadeOut( toggleTime );
                        $( '.sidebar-inner' ).fadeOut( toggleTime );

-- 
To view, visit https://gerrit.wikimedia.org/r/371624
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f78f1127c563ae3f81b6268eb896b2441ffd840
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to