Yurik has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371702 )

Change subject: Use `npm run` instead of `grunt`
......................................................................

Use `npm run` instead of `grunt`

* Added run scripts for build and deploy
* Updated readme to use `npm run` instead of `grunt`
* Fixed missing space in readme

Rationale: calling `grunt` from shell implies that its installed
as an apt package. Since grunt is also downloaded as part of
`npm install`, it is much cleaner to just have it installed once,
without requiring user to have both.  Both `grunt build` and `npm run build`
do the same thing.

Change-Id: I6ba254b399d55b9e5442e9254e17a8df4fa0cf13
---
M README.md
M package.json
2 files changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/02/371702/1

diff --git a/README.md b/README.md
index 01d346b..36d52f6 100644
--- a/README.md
+++ b/README.md
@@ -26,14 +26,14 @@
 Run JSHint, JSCS and QUnit tests.
 
 ```bash
-$ grunt test
+$ npm test
 ```
 
 ## Build
 Create a build with bundled and minified files.
 
 ```bash
-$ grunt build
+$ npm run build
 ```
 
 
@@ -41,7 +41,7 @@
 Create a build and push it to the deployment branch via git review.
 
 ```bash
-$ grunt deploy
+$ npm run deploy
 ```
 
 
@@ -72,7 +72,7 @@
 
 ```
 var api = new wikibase.queryService.api.Sparql();
-api.query( query ).done( function(){
+api.query( query ).done( function() {
        var json = JSON.parse( api.getResultAsJson() );
 
 } );
diff --git a/package.json b/package.json
index 4025e0b..ae6b46a 100644
--- a/package.json
+++ b/package.json
@@ -3,7 +3,9 @@
   "license": "GPL-2.0+",
   "version": "0.1.4",
   "scripts": {
-    "test": "grunt test"
+    "test": "grunt test",
+    "build": "grunt build",
+    "deploy": "grunt deploy"
   },
   "repository": {
     "type": "git",

-- 
To view, visit https://gerrit.wikimedia.org/r/371702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ba254b399d55b9e5442e9254e17a8df4fa0cf13
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Yurik <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to