BryanDavis has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371504 )

Change subject: Fix author tracking for toolinfo create/edit
......................................................................


Fix author tracking for toolinfo create/edit

Somewhere in the refactoring that was done around use of the reversion
library the attribution of the editor was lost.

Bug: T149458
Change-Id: Ibe86448114546ea031f6cc09444b67c86b4e2b0c
---
M striker/tools/views/toolinfo.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/striker/tools/views/toolinfo.py b/striker/tools/views/toolinfo.py
index def005a..1aecbf6 100644
--- a/striker/tools/views/toolinfo.py
+++ b/striker/tools/views/toolinfo.py
@@ -70,6 +70,7 @@
         if form.is_valid():
             try:
                 with reversion.create_revision():
+                    reversion.set_user(req.user)
                     reversion.set_comment(form.cleaned_data['comment'])
                     toolinfo = form.save(commit=False)
                     toolinfo.tool = tool.name
@@ -122,6 +123,7 @@
         if form.is_valid():
             try:
                 with reversion.create_revision():
+                    reversion.set_user(req.user)
                     reversion.set_comment(form.cleaned_data['comment'])
                     toolinfo = form.save()
                     reversion.add_to_revision(toolinfo)

-- 
To view, visit https://gerrit.wikimedia.org/r/371504
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe86448114546ea031f6cc09444b67c86b4e2b0c
Gerrit-PatchSet: 2
Gerrit-Project: labs/striker
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to