jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354595 )
Change subject: BaseTemplate: Handle `$this->data['language_urls'] === false`
specially
......................................................................
BaseTemplate: Handle `$this->data['language_urls'] === false` specially
Per 53ab861a2fcba98d876e5a2be5af7bc7186b880c, extensions can set this
to an empty array to have the sidebar section displayed even if it has
no items. Wikidata and UniversalLanguageSelector rely on this.
Change-Id: I79cef25d79ed25fa6d96698a121c3105870e890b
---
M includes/skins/BaseTemplate.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Brian Wolff: Looks good to me, approved
jenkins-bot: Verified
Isarra: Looks good to me, but someone else must approve
diff --git a/includes/skins/BaseTemplate.php b/includes/skins/BaseTemplate.php
index 5868904..e68969f 100644
--- a/includes/skins/BaseTemplate.php
+++ b/includes/skins/BaseTemplate.php
@@ -201,13 +201,13 @@
];
break;
case 'LANGUAGES':
- if ( $this->data['language_urls'] ) {
+ if ( $this->data['language_urls'] !== false ) {
$msgObj = $this->getMsg(
'otherlanguages' );
$boxes[$boxName] = [
'id' => 'p-lang',
'header' => $msgObj->exists() ?
$msgObj->text() : 'otherlanguages',
'generated' => false,
- 'content' =>
$this->data['language_urls'],
+ 'content' =>
$this->data['language_urls'] ?: [],
];
}
break;
--
To view, visit https://gerrit.wikimedia.org/r/354595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79cef25d79ed25fa6d96698a121c3105870e890b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Brian Wolff <[email protected]>
Gerrit-Reviewer: Isarra <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
