Dalba has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371771 )

Change subject: exceptions.py: Let Server504Error and Server414Error inherit 
from ServerError
......................................................................

exceptions.py: Let Server504Error and Server414Error inherit from ServerError

This is potentially a breaking change, but it makes sense and hopefully nobody
relies on catching a `ServerError` without catching `Server414Error` or
`Server504Error`.

Bug: T173289
Change-Id: I5f068886442d55aa0072815f4edbffbefa3577ae
---
M pywikibot/exceptions.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/71/371771/1

diff --git a/pywikibot/exceptions.py b/pywikibot/exceptions.py
index d9dff19..2914eb7 100644
--- a/pywikibot/exceptions.py
+++ b/pywikibot/exceptions.py
@@ -464,14 +464,14 @@
     pass
 
 
-class Server504Error(Error):  # noqa
+class Server504Error(ServerError):  # noqa
 
     """Server timed out with HTTP 504 code"""
 
     pass
 
 
-class Server414Error(Error):
+class Server414Error(ServerError):
 
     """Server returned with HTTP 414 code."""
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371771
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f068886442d55aa0072815f4edbffbefa3577ae
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba <dalba.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to