Isarra has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371952 )
Change subject: Make BaseTemplate::getFooter use 'footer' as default id, and
make id adjustible (was 'footer-bottom' because I wasn't paying attention)
......................................................................
Make BaseTemplate::getFooter use 'footer' as default id, and
make id adjustible (was 'footer-bottom' because I wasn't
paying attention)
'footer' being what pretty much every skin uses in general,
so that'll make it a lot easier to migrate.
No idea what to do about vector, which adds extra wrappers
for all the chunks in the footer.
Change-Id: I336b89b8a04c2f26260a594500d7ed019a5444ef
---
M includes/skins/BaseTemplate.php
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/52/371952/1
diff --git a/includes/skins/BaseTemplate.php b/includes/skins/BaseTemplate.php
index 8d5ce10..27fbc89 100644
--- a/includes/skins/BaseTemplate.php
+++ b/includes/skins/BaseTemplate.php
@@ -655,11 +655,12 @@
*
* @param string $iconStyle $option for getFooterIcons: "icononly",
"nocopyright"
* @param string $linkStyle $option for getFooterLinks: "flat"
+ * @param string $id id for footer block; defaults to 'footer'
*
* @return string html
* @since 1.29
*/
- protected function getFooter( $iconStyle = 'icononly', $linkStyle =
'flat' ) {
+ protected function getFooter( $iconStyle = 'icononly', $linkStyle =
'flat', $id = 'footer' ) {
$validFooterIcons = $this->getFooterIcons( $iconStyle );
$validFooterLinks = $this->getFooterLinks( $linkStyle );
@@ -667,7 +668,7 @@
if ( count( $validFooterIcons ) + count( $validFooterLinks ) >
0 ) {
$html .= Html::openElement( 'div', [
- 'id' => 'footer-bottom',
+ 'id' => $id,
'role' => 'contentinfo',
'lang' => $this->get( 'userlang' ),
'dir' => $this->get( 'dir' )
@@ -763,7 +764,3 @@
$html = MWDebug::getDebugHTML( $this->getSkin()->getContext() );
$html .= $this->get( 'bottomscripts' );
$html .= $this->get( 'reporttime' );
-
- return $html;
- }
-}
--
To view, visit https://gerrit.wikimedia.org/r/371952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I336b89b8a04c2f26260a594500d7ed019a5444ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Isarra <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
