Dereckson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371967 )

Change subject: Fix notice when no argument is given
......................................................................

Fix notice when no argument is given

Bug: T173342
Change-Id: I99ca485982ba5ce57c98e0cbebd413920c0095b9
---
M multiversion/bin/expanddblist
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/67/371967/1

diff --git a/multiversion/bin/expanddblist b/multiversion/bin/expanddblist
index 58b703e..10e877b 100755
--- a/multiversion/bin/expanddblist
+++ b/multiversion/bin/expanddblist
@@ -1,11 +1,14 @@
 #!/usr/bin/env php
 <?php
 require_once dirname( __DIR__ ) . '/MWWikiversions.php';
-$param = trim( $argv[1] );
-if ( !$param ) {
-       print "Usage: expanddblist [<dblist>, <dblistname> or <expression>]";
+
+if ( $argc < 2 ) {
+       print "Usage: expanddblist [<dblist>, <dblistname> or <expression>]\nb";
        exit( 1 );
 }
+
+$param = trim( $argv[1] );
+
 foreach ( MWWikiversions::evalDbListExpression( $param ) as $wiki ) {
        echo "$wiki\n";
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/371967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99ca485982ba5ce57c98e0cbebd413920c0095b9
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Dereckson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to