jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/371961 )
Change subject: JobQueueEventBus: not set properties are accessed
......................................................................
JobQueueEventBus: not set properties are accessed
Change-Id: I0f021d716a6ed5ae42e6ae811347007c2f667c20
(cherry picked from commit da7696eddec1807d65edfe59e5d7ddc26f1beec8)
---
M JobQueueEventBus.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Dereckson: Looks good to me, approved
diff --git a/JobQueueEventBus.php b/JobQueueEventBus.php
index ee7980e..b1da61f 100644
--- a/JobQueueEventBus.php
+++ b/JobQueueEventBus.php
@@ -96,10 +96,10 @@
foreach ( $jobs as $job ) {
$item = JobQueueEventBus::createJobEvent( $job );
// hash identifier => de-duplicate
- if ( strlen( $item['sha1'] ) ) {
+ if ( isset( $item['sha1'] ) ) {
$events[$item['sha1']] = $item;
} else {
- $events[$item['meta']['uuid']] = $item;
+ $events[$item['meta']['id']] = $item;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/371961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f021d716a6ed5ae42e6ae811347007c2f667c20
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventBus
Gerrit-Branch: wmf/1.30.0-wmf.11
Gerrit-Owner: Ppchelko <[email protected]>
Gerrit-Reviewer: Dereckson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
