Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372056 )
Change subject: getPreviewCountBucket should return unknown when no bucket is found ...................................................................... getPreviewCountBucket should return unknown when no bucket is found Under some unknown circumstances getPreviewCountBucket() is called with a value that is not a -1 or a natural number. When that happens function returns 'undefined bucket' which causes eventLogging to fail. I wasn't able to reproduce the issue, it might be specific to browser/os. The safest way is to return 'unknown' for any other case. Bug: T168371 Change-Id: I374bb629762a86ac06a18e775d3c1a14682c9f55 --- M resources/dist/index.js M resources/dist/index.js.map M src/counts.js M tests/node-qunit/counts.test.js 4 files changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/56/372056/1 -- To view, visit https://gerrit.wikimedia.org/r/372056 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I374bb629762a86ac06a18e775d3c1a14682c9f55 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Pmiazga <pmia...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
