Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372095 )
Change subject: Type-hint SpoofUser::batchRecord() for IDatabase
......................................................................
Type-hint SpoofUser::batchRecord() for IDatabase
While normal AntiSpoof will only pass in Database objects, CentralAuth
extends SpoofUser and passes in DBConnRef objects, so use the common
interface of IDatabase.
Bug: T173394
Change-Id: I831d27ea15ae457467033d19136992b5c79c23d1
---
M SpoofUser.php
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AntiSpoof
refs/changes/95/372095/1
diff --git a/SpoofUser.php b/SpoofUser.php
index 8938a23..f1e8222 100644
--- a/SpoofUser.php
+++ b/SpoofUser.php
@@ -1,6 +1,6 @@
<?php
-use Wikimedia\Rdbms\Database;
+use Wikimedia\Rdbms\IDatabase;
class SpoofUser {
/** @var bool */
@@ -121,11 +121,11 @@
/**
* Insert a batch of spoof normalization records into the database.
- * @param Database $dbw
+ * @param IDatabase $dbw
* @param SpoofUser[] $items
* @return bool
*/
- public static function batchRecord( Database $dbw, $items ) {
+ public static function batchRecord( IDatabase $dbw, $items ) {
if ( !count( $items ) ) {
return false;
}
@@ -177,14 +177,14 @@
}
/**
- * @return Database
+ * @return IDatabase
*/
protected function getDBSlave() {
return wfGetDB( DB_SLAVE );
}
/**
- * @return Database
+ * @return IDatabase
*/
protected function getDBMaster() {
return wfGetDB( DB_MASTER );
--
To view, visit https://gerrit.wikimedia.org/r/372095
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I831d27ea15ae457467033d19136992b5c79c23d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AntiSpoof
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
