Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372111 )
Change subject: build: Update mediawiki/mediawiki-codesniffer to 0.11.1
......................................................................
build: Update mediawiki/mediawiki-codesniffer to 0.11.1
Change-Id: I6f4fb19895b2b62004079bfe8ee63eaea9c14be5
---
M composer.json
M includes/MobileContext.php
M includes/MobileFrontend.hooks.php
M includes/api/ApiWebappManifest.php
M includes/specials/SpecialMobileDiff.php
M includes/specials/SpecialMobileWatchlist.php
M tests/phpunit/MobileFormatterTest.php
M tests/phpunit/devices/DeviceDetectorServiceIntegrationTest.php
8 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/11/372111/1
diff --git a/composer.json b/composer.json
index 55507be..f80e32e 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.10.1",
+ "mediawiki/mediawiki-codesniffer": "0.11.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/MobileContext.php b/includes/MobileContext.php
index 330a39a..fbadd60 100644
--- a/includes/MobileContext.php
+++ b/includes/MobileContext.php
@@ -157,7 +157,7 @@
*/
public function getMFConfig() {
/** @var Config $config */
- $config = MediaWikiServices::getInstance()->getService(
'MobileFrontend.Config' );
+ $config = MediaWikiServices::getInstance()->getService(
'MobileFrontend.Config' );
return $config;
}
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 40f2379..594fac5 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -193,7 +193,7 @@
public static function onOutputPageBeforeHTML( &$out, &$text ) {
$context = MobileContext::singleton();
$title = $context->getTitle();
- $config = $context->getMFConfig();
+ $config = $context->getMFConfig();
if ( !$title ) {
return true;
@@ -428,8 +428,8 @@
'wgMFSearchGenerator' => $config->get(
'MFSearchGenerator' ),
'wgMFNearbyEndpoint' => $config->get(
'MFNearbyEndpoint' ),
'wgMFThumbnailSizes' => [
- 'tiny' => MobilePage::TINY_IMAGE_WIDTH,
- 'small' => MobilePage::SMALL_IMAGE_WIDTH,
+ 'tiny' => MobilePage::TINY_IMAGE_WIDTH,
+ 'small' => MobilePage::SMALL_IMAGE_WIDTH,
],
'wgMFEditorOptions' => $config->get( 'MFEditorOptions'
),
'wgMFLicense' => MobileFrontendSkinHooks::getLicense(
'editor' ),
diff --git a/includes/api/ApiWebappManifest.php
b/includes/api/ApiWebappManifest.php
index d70ccc7..d2b167c 100644
--- a/includes/api/ApiWebappManifest.php
+++ b/includes/api/ApiWebappManifest.php
@@ -47,7 +47,7 @@
$resultObj->addValue( null, 'icons', $icons );
$main = $this->getMain();
- $main->setCacheControl( [ 's-maxage'=>86400, 'max-age'=>86400 ]
);
+ $main->setCacheControl( [ 's-maxage' => 86400, 'max-age' =>
86400 ] );
$main->setCacheMode( 'public' );
}
diff --git a/includes/specials/SpecialMobileDiff.php
b/includes/specials/SpecialMobileDiff.php
index e109baf..39d9133 100644
--- a/includes/specials/SpecialMobileDiff.php
+++ b/includes/specials/SpecialMobileDiff.php
@@ -294,7 +294,7 @@
$userPage = SpecialPage::getTitleFor( 'Contributions',
$ipAddr );
$output->addHtml(
Html::element( 'div', [
- 'class' => MobileUI::iconClass(
'anonymous', 'before', 'mw-mf-user mw-mf-anon' ),
+ 'class' => MobileUI::iconClass(
'anonymous', 'before', 'mw-mf-user mw-mf-anon' ),
], $this->msg(
'mobile-frontend-diffview-anonymous' ) ) .
'<div>' .
$this->getLinkRenderer()->makeLink(
$userPage, $ipAddr ) .
diff --git a/includes/specials/SpecialMobileWatchlist.php
b/includes/specials/SpecialMobileWatchlist.php
index 19e6a0f..e381e51 100644
--- a/includes/specials/SpecialMobileWatchlist.php
+++ b/includes/specials/SpecialMobileWatchlist.php
@@ -72,7 +72,7 @@
# Show watchlist feed if that person is an editor
$watchlistEditCountThreshold = $this->getConfig()->get(
'MFWatchlistEditCountThreshold' );
- $defaultView = $this->getUser()->getEditCount() >
$watchlistEditCountThreshold ? 'feed' : 'a-z';
+ $defaultView = $this->getUser()->getEditCount() >
$watchlistEditCountThreshold ? 'feed' : 'a-z';
$this->view = $req->getVal( 'watchlistview', $defaultView );
$this->filter = $req->getVal( 'filter', 'all' );
diff --git a/tests/phpunit/MobileFormatterTest.php
b/tests/phpunit/MobileFormatterTest.php
index 0046e68..3974697 100644
--- a/tests/phpunit/MobileFormatterTest.php
+++ b/tests/phpunit/MobileFormatterTest.php
@@ -84,7 +84,7 @@
* @covers MobileFormatter::skipLazyLoadingForSmallDimensions
*/
public function testHtmlTransformWhenSkippingLazyLoadingSmallImages() {
- $smallPic = '<img src="smallPicture.jpg" style="width: 4.4ex;
height:3.34ex;">';
+ $smallPic = '<img src="smallPicture.jpg" style="width: 4.4ex;
height:3.34ex;">';
$enableSections = function ( MobileFormatter $mf ) {
$mf->enableExpandableSections();
};
diff --git a/tests/phpunit/devices/DeviceDetectorServiceIntegrationTest.php
b/tests/phpunit/devices/DeviceDetectorServiceIntegrationTest.php
index eccc27c..50f8324 100644
--- a/tests/phpunit/devices/DeviceDetectorServiceIntegrationTest.php
+++ b/tests/phpunit/devices/DeviceDetectorServiceIntegrationTest.php
@@ -62,7 +62,7 @@
}
public function test_it_should_handle_a_request_from_desktop_browsers()
{
- $properties = $this->detectDeviceProperties();
+ $properties = $this->detectDeviceProperties();
$this->assertFalse( $properties->isMobileDevice() );
$this->assertFalse( $properties->isTabletDevice() );
@@ -76,7 +76,7 @@
$this->request->setHeader( 'X-Subdomain', 'M' );
- $properties = $this->detectDeviceProperties();
+ $properties = $this->detectDeviceProperties();
$this->assertTrue( $properties->isMobileDevice() );
$this->assertFalse( $properties->isTabletDevice() );
@@ -90,7 +90,7 @@
$this->server[ 'AMF_DEVICE_IS_TABLET' ] = 'true';
- $properties = $this->detectDeviceProperties();
+ $properties = $this->detectDeviceProperties();
$this->assertFalse(
$properties->isMobileDevice(),
--
To view, visit https://gerrit.wikimedia.org/r/372111
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f4fb19895b2b62004079bfe8ee63eaea9c14be5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
