jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364618 )
Change subject: Add hidden field for base revision id in editing entities
special pages
......................................................................
Add hidden field for base revision id in editing entities special pages
This later will be needed when detecting edit conflicts
Bug: T170805
Change-Id: Ic754ae6f0c850511a54910fdfc31ac8538c5f835
---
M repo/includes/Specials/SpecialModifyTerm.php
M repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
M repo/includes/Specials/SpecialSetSiteLink.php
3 files changed, 16 insertions(+), 1 deletion(-)
Approvals:
Ladsgroup: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/Specials/SpecialModifyTerm.php
b/repo/includes/Specials/SpecialModifyTerm.php
index 68d5561..247a4bf 100644
--- a/repo/includes/Specials/SpecialModifyTerm.php
+++ b/repo/includes/Specials/SpecialModifyTerm.php
@@ -249,7 +249,12 @@
'type' => 'hidden',
'default' => 'remove'
],
- 'value' => $valueinput
+ 'value' => $valueinput,
+ 'revid' => [
+ 'name' => 'revid',
+ 'type' => 'hidden',
+ 'default' =>
$this->getBaseRevision()->getRevisionId(),
+ ],
];
} else {
// Messages:
diff --git a/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
b/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
index c07f485..01d88fd 100644
--- a/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
+++ b/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
@@ -164,6 +164,11 @@
'name' => 'language',
'type' => 'hidden',
'default' => $this->languageCode
+ ],
+ 'revid' => [
+ 'name' => 'revid',
+ 'type' => 'hidden',
+ 'default' =>
$this->getBaseRevision()->getRevisionId(),
]
];
$formDescriptor = array_merge(
diff --git a/repo/includes/Specials/SpecialSetSiteLink.php
b/repo/includes/Specials/SpecialSetSiteLink.php
index ddf3f81..0ab6021 100644
--- a/repo/includes/Specials/SpecialSetSiteLink.php
+++ b/repo/includes/Specials/SpecialSetSiteLink.php
@@ -284,6 +284,11 @@
'name' => 'remove',
'type' => 'hidden',
'default' => 'remove'
+ ],
+ 'revid' => [
+ 'name' => 'revid',
+ 'type' => 'hidden',
+ 'default' =>
$this->getBaseRevision()->getRevisionId(),
]
];
} else {
--
To view, visit https://gerrit.wikimedia.org/r/364618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic754ae6f0c850511a54910fdfc31ac8538c5f835
Gerrit-PatchSet: 14
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: AnotherLadsgroup <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: AnotherLadsgroup <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
