Elukey has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/372129 )
Change subject: role::analytics_cluster::monitoring::disk: remove unused role
......................................................................
role::analytics_cluster::monitoring::disk: remove unused role
Bug: T167790
Change-Id: Ia6947ffae1781e8a0552cf9f1868379d0672c77a
---
M modules/role/manifests/analytics_cluster/hadoop/master.pp
M modules/role/manifests/analytics_cluster/hadoop/standby.pp
M modules/role/manifests/analytics_cluster/hadoop/worker.pp
D modules/role/manifests/analytics_cluster/monitoring/disks.pp
4 files changed, 0 insertions(+), 13 deletions(-)
Approvals:
Elukey: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/role/manifests/analytics_cluster/hadoop/master.pp
b/modules/role/manifests/analytics_cluster/hadoop/master.pp
index 6fe82d3..a4f9a05 100644
--- a/modules/role/manifests/analytics_cluster/hadoop/master.pp
+++ b/modules/role/manifests/analytics_cluster/hadoop/master.pp
@@ -8,7 +8,6 @@
}
require ::profile::hadoop::client
- include ::role::analytics_cluster::monitoring::disks
class { '::druid::cdh::hadoop::setup': }
diff --git a/modules/role/manifests/analytics_cluster/hadoop/standby.pp
b/modules/role/manifests/analytics_cluster/hadoop/standby.pp
index 243a7b1..61a63f8 100644
--- a/modules/role/manifests/analytics_cluster/hadoop/standby.pp
+++ b/modules/role/manifests/analytics_cluster/hadoop/standby.pp
@@ -7,7 +7,6 @@
description => 'Hadoop Standby NameNode',
}
require ::profile::hadoop::client
- include ::role::analytics_cluster::monitoring::disks
class { '::druid::cdh::hadoop::setup': }
diff --git a/modules/role/manifests/analytics_cluster/hadoop/worker.pp
b/modules/role/manifests/analytics_cluster/hadoop/worker.pp
index 69c6625..610629b 100644
--- a/modules/role/manifests/analytics_cluster/hadoop/worker.pp
+++ b/modules/role/manifests/analytics_cluster/hadoop/worker.pp
@@ -8,7 +8,6 @@
}
require ::profile::hadoop::client
- include ::role::analytics_cluster::monitoring::disks
class { '::cdh::hadoop::worker': }
diff --git a/modules/role/manifests/analytics_cluster/monitoring/disks.pp
b/modules/role/manifests/analytics_cluster/monitoring/disks.pp
deleted file mode 100644
index d350007..0000000
--- a/modules/role/manifests/analytics_cluster/monitoring/disks.pp
+++ /dev/null
@@ -1,10 +0,0 @@
-# == Class role::analytics_cluster::monitoring::disks
-# Installs ganglia monitoring plugins for disks
-#
-class role::analytics_cluster::monitoring::disks {
- include ::standard
-
- if $::standard::has_ganglia {
- ganglia::plugin::python { 'diskstat': }
- }
-}
--
To view, visit https://gerrit.wikimedia.org/r/372129
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6947ffae1781e8a0552cf9f1868379d0672c77a
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <[email protected]>
Gerrit-Reviewer: Elukey <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
