Jakob has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372142 )
Change subject: Use unexpectedJS expectations in QUnit.
......................................................................
Use unexpectedJS expectations in QUnit.
Change-Id: I72d52540a66e6daa2fa412993fa2f9187c096f1e
---
M package.json
M tests/qunit/widgets/RepresentationWidget.tests.js
2 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/42/372142/1
diff --git a/package.json b/package.json
index 1a2efa9..fff088b 100644
--- a/package.json
+++ b/package.json
@@ -16,6 +16,7 @@
"jsdom-global": "^3.0.2",
"module-alias": "^2.0.0",
"qunitjs": "^2.4.0",
+ "unexpected": "^10.33.2",
"vue": "2.3.3"
},
"_moduleAliases": {
diff --git a/tests/qunit/widgets/RepresentationWidget.tests.js
b/tests/qunit/widgets/RepresentationWidget.tests.js
index d7fece1..d1cd613 100644
--- a/tests/qunit/widgets/RepresentationWidget.tests.js
+++ b/tests/qunit/widgets/RepresentationWidget.tests.js
@@ -4,6 +4,11 @@
( function ( QUnit ) {
'use strict';
require( 'module-alias/register' );
+ var originalExpect = require( 'unexpected' ).clone();
+ var expect = function ( args ) {
+ QUnit.assert.ok( true );
+ originalExpect.apply( this, arguments );
+ };
global.mediaWiki = {
messages: {
@@ -26,12 +31,12 @@
function () {
QUnit.test(
'widget without representations, start editing
- new empty representation is added',
- function ( assert ) {
+ function () {
var widget = newWidget( [] );
widget.edit();
- assert.deepEqual(
widget.representations, [ EMPTY_REPRESENTATION ] );
+ expect( widget.representations, 'to
equal', [ EMPTY_REPRESENTATION ] );
}
);
@@ -52,7 +57,7 @@
QUnit.test( 'when created - not in edit mode', function
( assert ) {
var widget = newWidget( [] );
- assert.notOk( widget.inEditMode );
+ expect( widget.inEditMode, 'to be', false );
} );
QUnit.test( 'switch to edit mode', function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/372142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72d52540a66e6daa2fa412993fa2f9187c096f1e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Jakob <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
