Ladsgroup has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372147 )
Change subject: Fix usages of dieWithError in CreateClaim
......................................................................
Fix usages of dieWithError in CreateClaim
This takes some parts of I0d2a4712353e8bf53dd7c0e4e8c0125201db3761 out of the
patch
Change-Id: I2bde59208cedfae201e841c0ebdeb20f27d231fd
---
M repo/includes/Api/CreateClaim.php
1 file changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/47/372147/1
diff --git a/repo/includes/Api/CreateClaim.php
b/repo/includes/Api/CreateClaim.php
index 56837c7..1224620 100644
--- a/repo/includes/Api/CreateClaim.php
+++ b/repo/includes/Api/CreateClaim.php
@@ -114,25 +114,30 @@
private function validateParameters( array $params ) {
if ( $params['snaktype'] === 'value' xor isset(
$params['value'] ) ) {
if ( $params['snaktype'] === 'value' ) {
- $this->errorReporter->dieWithError( [
'param-missing', 'value' ],
+ $this->errorReporter->dieWithError(
+ [ 'wikibase-api-claim-value-missing' ],
'param-missing'
);
} else {
- $this->errorReporter->dieError(
- 'You cannot provide a value when
creating a claim with no PropertyValueSnak as main snak',
+ $this->errorReporter->dieWithError(
+ [ 'wikibase-api-claim-value-unexpected'
],
'param-illegal'
);
}
}
if ( !isset( $params['property'] ) ) {
- $this->errorReporter->dieWithError( [ 'param-missing',
'property' ],
+ $this->errorReporter->dieWithError(
+ [ 'wikibase-api-param-missing', 'property' ],
'param-missing'
);
}
if ( isset( $params['value'] ) && json_decode(
$params['value'], true ) === null ) {
- $this->errorReporter->dieError( 'Could not decode snak
value', 'invalid-snak' );
+ $this->errorReporter->dieWithError(
+ [ 'wikibase-api-invalid-snak' ],
+ 'invalid-snak'
+ );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/372147
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bde59208cedfae201e841c0ebdeb20f27d231fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
