Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372149 )

Change subject: Chore: remove unused Webpack plugin
......................................................................

Chore: remove unused Webpack plugin

- Remove NamedModulesPlugin until we need it.
- Fix unrelated server console message.

Change-Id: Iccab3fb86418769225414f7fcfd0663a4dafa0b2
---
M src/server/index.ts
M webpack.config.js
2 files changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/49/372149/1

diff --git a/src/server/index.ts b/src/server/index.ts
index 803eabf..670ff11 100644
--- a/src/server/index.ts
+++ b/src/server/index.ts
@@ -23,7 +23,7 @@
 });
 
 server.listen(PORT, () => {
-  console.log(`Server started on port http://localhost:${PORT}/`); // 
eslint-disable-line no-console
+  console.log(`Server started on http://localhost:${PORT}/`); // 
eslint-disable-line no-console
 
   if (!isProd) {
     const touch = require("touch");
diff --git a/webpack.config.js b/webpack.config.js
index 0e34c54..cbdf84c 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -1,6 +1,5 @@
 /* eslint-env node */
 const path = require("path");
-const webpack = require("webpack");
 const AssetsPlugin = require("assets-webpack-plugin");
 
 const isProd = process.env.NODE_ENV === "production";
@@ -75,8 +74,7 @@
         stats: WARNINGS_STATS_PRESET
       },
 
-  // Use path names instead of autogenerated ids for asset names
-  plugins: [new webpack.NamedModulesPlugin()]
+  plugins: []
 };
 
 if (isProd) {

-- 
To view, visit https://gerrit.wikimedia.org/r/372149
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccab3fb86418769225414f7fcfd0663a4dafa0b2
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to