Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372183 )
Change subject: Do not assume MobileFrontend special pages exist
......................................................................
Do not assume MobileFrontend special pages exist
If they don't exist attempts to use them will throw errors.
This will only happen if MobileFrontend is not installed
Change-Id: Iee674011bbd59d79914a144d1738b912eceea6b1
---
M includes/skins/SkinMinerva.php
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/83/372183/1
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 558b560..850d14e 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -629,6 +629,7 @@
// Nearby link (if supported)
if (
+ SpecialPageFactory::exists( 'Nearby' ) &&
$config->get( 'MFNearby' ) &&
( $config->get( 'MFNearbyEndpoint' ) || class_exists(
'GeoData\GeoData' ) )
) {
@@ -738,11 +739,18 @@
$this->getLanguage()->userTime( $timestamp,
$user )
)->parse();
}
+
+ if ( SpecialPageFactory::exists( 'History' ) ) {
+ $historyUrl = SpecialPage::getTitleFor( 'History',
$title )->getLocalURL();
+ } else {
+ $historyUrl = $title->getLocalURL( [ 'action' =>
'history' ] );
+ }
+
$edit = $mp->getLatestEdit();
$link = [
// Use $edit['timestamp'] (Unix format) instead of
$timestamp (MW format)
'data-timestamp' => $isMainPage ? '' :
$edit['timestamp'],
- 'href' => SpecialPage::getTitleFor( 'History', $title
)->getLocalURL(),
+ 'href' => $historyUrl,
'text' => $lastModified,
'data-user-name' => $edit['name'],
'data-user-gender' => $edit['gender'],
@@ -864,7 +872,9 @@
*/
protected function prepareMenuButton( BaseTemplate $tpl ) {
// menu button
- $url = SpecialPage::getTitleFor( 'MobileMenu' )->getLocalUrl();
+ $url = SpecialPageFactory::exists( 'MobileMenu' ) ?
+ SpecialPage::getTitleFor( 'MobileMenu' )->getLocalUrl()
: '#';
+
$tpl->set( 'menuButton',
Html::element( 'a', [
'title' => $this->msg(
'mobile-frontend-main-menu-button-tooltip' ),
--
To view, visit https://gerrit.wikimedia.org/r/372183
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee674011bbd59d79914a144d1738b912eceea6b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
