BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372204 )
Change subject: Hygiene: rename function pageContentPromise to pageJsonPromise
......................................................................
Hygiene: rename function pageContentPromise to pageJsonPromise
There will be a new pageHtmlPromise soon.
Change-Id: Ia021018849b462b72ec737dd082d03dbb2bfd916
---
M lib/parsoid-access.js
M routes/media.js
M routes/mobile-sections.js
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/04/372204/1
diff --git a/lib/parsoid-access.js b/lib/parsoid-access.js
index b6df4b8..a9de6ef 100644
--- a/lib/parsoid-access.js
+++ b/lib/parsoid-access.js
@@ -171,7 +171,7 @@
* and hiding IPA via an inline style rather than clas.
* @return {!promise} Returns a promise to retrieve the page content from
Parsoid
*/
-function pageContentPromise(app, req, legacy) {
+function pageJsonPromise(app, req, legacy) {
return getParsoidHtml(app, req)
.then((response) => {
const page = { revision: getRevisionFromEtag(response.headers) };
@@ -234,7 +234,7 @@
}
module.exports = {
- pageContentPromise,
+ pageJsonPromise,
definitionPromise,
getParsoidHtml,
getRevisionFromEtag,
diff --git a/routes/media.js b/routes/media.js
index 3b722c8..0f84af6 100644
--- a/routes/media.js
+++ b/routes/media.js
@@ -22,7 +22,7 @@
*/
router.get('/media/:title', (req, res) => {
return BBPromise.props({
- page: parsoid.pageContentPromise(app, req),
+ page: parsoid.pageJsonPromise(app, req),
media: gallery.collectionPromise(app, req)
}).then((response) => {
res.status(200);
diff --git a/routes/mobile-sections.js b/routes/mobile-sections.js
index 645e927..1debf1a 100644
--- a/routes/mobile-sections.js
+++ b/routes/mobile-sections.js
@@ -296,7 +296,7 @@
*/
function _collectRawPageData(req, legacy) {
return BBPromise.props({
- page: parsoid.pageContentPromise(app, req, legacy),
+ page: parsoid.pageJsonPromise(app, req, legacy),
meta: mwapi.getMetadata(app, req)
}).then((interimState) => {
return _handleNamespaceAndSpecialCases(req, interimState);
@@ -404,7 +404,7 @@
*/
router.get('/mobile-sections-remaining/:title/:revision?/:tid?', (req, res) =>
{
return BBPromise.props({
- page: parsoid.pageContentPromise(app, req, true)
+ page: parsoid.pageJsonPromise(app, req, true)
}).then((response) => {
res.status(200);
mUtil.setETag(res, response.page.revision);
@@ -419,7 +419,7 @@
*/
router.get('/references/:title/:revision?/:tid?', (req, res) => {
return BBPromise.props({
- page: parsoid.pageContentPromise(app, req, false)
+ page: parsoid.pageJsonPromise(app, req, false)
}).then((response) => {
res.status(200);
mUtil.setETag(res, response.page.revision);
--
To view, visit https://gerrit.wikimedia.org/r/372204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia021018849b462b72ec737dd082d03dbb2bfd916
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
