Aaron Schulz has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372345 )
Change subject: [WIP] Avoid lock acquisition errors for multi-title
refreshlinks jobs
......................................................................
[WIP] Avoid lock acquisition errors for multi-title refreshlinks jobs
Bug: T173462
Change-Id: I9dab9b4e5c4cae7306dc29bad9e62287d54b2281
---
M includes/jobqueue/jobs/RefreshLinksJob.php
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/45/372345/1
diff --git a/includes/jobqueue/jobs/RefreshLinksJob.php
b/includes/jobqueue/jobs/RefreshLinksJob.php
index 02bb829..0c84a13 100644
--- a/includes/jobqueue/jobs/RefreshLinksJob.php
+++ b/includes/jobqueue/jobs/RefreshLinksJob.php
@@ -279,6 +279,10 @@
InfoAction::invalidateCache( $title );
+ // Commit any writes here in case this method is called in a
loop.
+ // In that case, the scoped lock will fail to be acquired.
+ $lbFactory->commitAndWaitForReplication( __METHOD__, $ticket );
+
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/372345
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9dab9b4e5c4cae7306dc29bad9e62287d54b2281
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
