jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/372347 )
Change subject: BSContextMenu: Fixed links for IE11 ...................................................................... BSContextMenu: Fixed links for IE11 * The menu DOM elements got removed before the click event could bubble up. Therefore IE11 did not execute the navigation * Also removed unused code * Also fixed typo See https://sourceforge.net/p/bluespice/bugs/424/ NEEDS CHERRY-PICK TO REL1_27 AND REL1_23 Change-Id: Id1e2d278fb76fa3b844eedec6d7d7694e09f6070 --- M ContextMenu/resources/bluespice.contextmenu.js 1 file changed, 13 insertions(+), 14 deletions(-) Approvals: Pwirth: Looks good to me, approved jenkins-bot: Verified diff --git a/ContextMenu/resources/bluespice.contextmenu.js b/ContextMenu/resources/bluespice.contextmenu.js index e703073..372f736 100644 --- a/ContextMenu/resources/bluespice.contextmenu.js +++ b/ContextMenu/resources/bluespice.contextmenu.js @@ -1,22 +1,21 @@ (function(mw, $, bs){ + var menu = null; + var showMenu = function( anchor, items, e ) { $(document).trigger( 'BSContextMenuBeforeCreate', [anchor, items]); - var menu = new Ext.menu.Menu({ + /* + * Unfortunately ExtJS does not use "close" when the context + * menu disappears, but "hide". Therefore closeAction: 'destroy', + * which is default does not work. But as we use DOM IDs we + * really need to remove the them from the DOM, otherwise we + * get ugly collisions when a second menu is opened. + */ + Ext.destroy(menu); + + menu = new Ext.menu.Menu({ id: 'bs-cm-menu', - items: items, - listeners: { - /* - * Unfortunately ExtJS does not use "close" when the context - * menu disappears, but hide. Therefore closeAction: 'destroy', - * wich is default does not work. But as we use DOM IDs we - * really need to remove the tem from the DOM, otherwise we - * get ugly collisions when a secon menu is opened. - */ - hide:function(menu, opt){ - Ext.destroy(menu); - } - } + items: items }); menu.showAt(e.pageX, e.pageY); -- To view, visit https://gerrit.wikimedia.org/r/372347 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1e2d278fb76fa3b844eedec6d7d7694e09f6070 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions Gerrit-Branch: REL1_23 Gerrit-Owner: Pwirth <[email protected]> Gerrit-Reviewer: Pwirth <[email protected]> Gerrit-Reviewer: Robert Vogel <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
