Elukey has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372354 )

Change subject: role::cache::kafka::webrequest: fix alert varnishkafka metrics
......................................................................

role::cache::kafka::webrequest: fix alert varnishkafka metrics

Rollback to the previous scheme since the new metric does not work
well and it is malformed. For the moment I am lowering down the
thresholds to be more sensitive.

Bug: T172681
Change-Id: I3bd7783b9ef75810f8b7c00c7357ba8a855219d0
---
M modules/role/manifests/cache/kafka/webrequest.pp
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/54/372354/1

diff --git a/modules/role/manifests/cache/kafka/webrequest.pp 
b/modules/role/manifests/cache/kafka/webrequest.pp
index 79fbbc4..afe4beb 100644
--- a/modules/role/manifests/cache/kafka/webrequest.pp
+++ b/modules/role/manifests/cache/kafka/webrequest.pp
@@ -145,15 +145,13 @@
     monitoring::graphite_threshold { 'varnishkafka-kafka_drerr':
         ensure      => 'present',
         description => 'Varnishkafka Delivery Errors per minute',
-        metric      => 
"sumSeries(summarize(perSecond(${graphite_metric_prefix}.varnishkafka.kafka_drerr),
 2h, sum, false))",
-        # More than 0 errors is warning threshold.
+        metric      => 
"derivative(transformNull(${graphite_metric_prefix}.varnishkafka.kafka_drerr, 
0))",
         warning     => 0,
-        # More than 20000 errors is critical threshold.
-        critical    => 5,
+        critical    => 5000,
         # But only alert if a large percentage of the examined datapoints
         # are over the threshold.
         percentage  => 80,
-        from        => '2hours',
+        from        => '10min',
         require     => Logster::Job['varnishkafka-webrequest'],
     }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/372354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bd7783b9ef75810f8b7c00c7357ba8a855219d0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to