jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/369472 )
Change subject: Decode text as UTF8
......................................................................
Decode text as UTF8
In Python 2 it by default uses ASCII to decode the command output, but that
will fail if the commit message contains non-ASCII characters. The next best
choice is to assume UTF8 will work.
Change-Id: Ib81b57212147a51b482703798cfe355946b915a6
---
M commit_message_validator/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/commit_message_validator/__init__.py
b/commit_message_validator/__init__.py
index 848d61b..7b05a40 100644
--- a/commit_message_validator/__init__.py
+++ b/commit_message_validator/__init__.py
@@ -248,7 +248,7 @@
def check_output(args):
"""Wrapper around subprocess to handle Python 3"""
- return subprocess.check_output(args).decode()
+ return subprocess.check_output(args).decode("utf8")
def main(commit_id='HEAD'):
--
To view, visit https://gerrit.wikimedia.org/r/369472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib81b57212147a51b482703798cfe355946b915a6
Gerrit-PatchSet: 1
Gerrit-Project: integration/commit-message-validator
Gerrit-Branch: master
Gerrit-Owner: XZise <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
