Arlolra has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372422 )
Change subject: Remove inline styling for vertical alignment in traditional
galleries
......................................................................
Remove inline styling for vertical alignment in traditional galleries
Depends-On: I718f16dfbb2c4122ac9fb4a714b607da3e62d5a0
Change-Id: Ief55da2cbe29096a78a7ba6584e6a6f3a5a92a04
---
M lib/ext/Gallery/modes.js
1 file changed, 0 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/22/372422/1
diff --git a/lib/ext/Gallery/modes.js b/lib/ext/Gallery/modes.js
index a2d3862..e43dc26 100644
--- a/lib/ext/Gallery/modes.js
+++ b/lib/ext/Gallery/modes.js
@@ -56,23 +56,6 @@
ul.appendChild(li);
};
-Traditional.prototype.verticalAlign = function(doc, thumb, wrapper) {
- if (this.mode !== 'traditional') { return; }
- // `helper` and `wrapper` are from http://stackoverflow.com/a/7310398
- // avoid the need to calculate paddings individually
- var helper = doc.createElement('span');
- helper.setAttribute('style', [
- 'display: inline-block;',
- 'height: 100%;',
- 'vertical-align: middle;',
- ].join(' '));
- thumb.appendChild(helper);
- wrapper.setAttribute('style', [
- 'vertical-align: middle;',
- 'display: inline-block;',
- ].join(' '));
-};
-
Traditional.prototype.dimensions = function(opts) {
return coreutil.format('%dx%dpx', opts.imageWidth, opts.imageHeight);
};
@@ -133,7 +116,6 @@
wrapper.setAttribute('typeof', o.rdfaType);
}
DU.migrateChildrenBetweenDocs(o.thumb, wrapper);
- this.verticalAlign(doc, thumb, wrapper);
thumb.appendChild(wrapper);
box.appendChild(thumb);
--
To view, visit https://gerrit.wikimedia.org/r/372422
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief55da2cbe29096a78a7ba6584e6a6f3a5a92a04
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
