Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54142
Change subject: (linkItem) Always dismiss tooltips on dialog click
......................................................................
(linkItem) Always dismiss tooltips on dialog click
also on dialog close
Change-Id: Ibb07607274a194f8086a2b1e1e1c1c73b4315c6b
---
M client/resources/wbclient.linkItem.js
1 file changed, 3 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/42/54142/1
diff --git a/client/resources/wbclient.linkItem.js
b/client/resources/wbclient.linkItem.js
index 7c37ac4..f30cb17 100644
--- a/client/resources/wbclient.linkItem.js
+++ b/client/resources/wbclient.linkItem.js
@@ -638,13 +638,9 @@
removeSpinner();
tooltip.show();
- // Remove the tooltip if the user tries to correct the input
- $elem.one( ['click', 'focus'], function() {
- tooltip.destroy();
- } );
- $( '#wbclient-linkItem-Site' ).one( 'click focus', function() {
- // Do the same if there's a site input...
- // We don't have to check whether this exists as jQuery
is smart
+ // Remove the tooltip if the user clicks onto the dialog trying
to correct the input
+ // Also remove the tooltip in case the dialog is getting closed
+ $dialog.on( 'dialogclose click', function() {
tooltip.destroy();
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/54142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb07607274a194f8086a2b1e1e1c1c73b4315c6b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
