jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/372411 )
Change subject: if preview count stored in localStorage is not a number override it ...................................................................... if preview count stored in localStorage is not a number override it There are some cases when the preview count stored in local storage evaluates to NaN. When this happens we should override the value to zero, store it in localStorage, and return it. Bug: T168371 Change-Id: Ic44b7c7b5b716f6a0859f33278d56d2d95bbfb3e --- M resources/dist/index.js M resources/dist/index.js.map M src/userSettings.js M tests/node-qunit/userSettings.test.js 4 files changed, 18 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/372411 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic44b7c7b5b716f6a0859f33278d56d2d95bbfb3e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Pmiazga <[email protected]> Gerrit-Reviewer: Bmansurov <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Pmiazga <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
