jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/371129 )
Change subject: Popups A/B test infrastructure ...................................................................... Popups A/B test infrastructure Introduce PopupsAnonsExperimentalGroupSize config variable. This defines a population size who will be subject to experimentation. If the group size is undefined or 0 (default) and PopupsBetaFeature is false (default value) Popups will be enabled for everyone. If it is any other value, half that group will see page previews. Drop the config variable PopupsSchemaSamplingRate - we will now only EventLog when an experiment is occuring. This means we can simplify the MWEventLogger class as shouldLog will always be truthy. Given server side eventlogging is only used for preference changes traffic should be low and not need sampling. Introduce getUserBucket which determines whether a user is in a bucket on, off or control based on the value of PopupsAnonsExperimentalGroupSize. Add tests showing how these buckets are calculated. Caution: A kill switch wgPopupsEventLogging is provided for safety. It defaults to false. Before merging, please check if any config changes are necessary. Bug: T171853 Change-Id: If2a0c5fceae78262c44cb522af38a925cc5919d3 --- M extension.json M includes/EventLogging/MWEventLogger.php M includes/PopupsHooks.php M resources/dist/index.js M resources/dist/index.js.map M src/constants.js A src/getUserBucket.js M src/index.js M src/instrumentation/eventLogging.js M src/isEnabled.js A tests/node-qunit/getUserBucket.test.js M tests/node-qunit/instrumentation/eventLogging.test.js M tests/node-qunit/isEnabled.test.js M tests/node-qunit/stubs.js D tests/phpunit/EventLogging/MWEventLoggerTest.php M tests/phpunit/PopupsHooksTest.php 16 files changed, 195 insertions(+), 208 deletions(-) Approvals: Bmansurov: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/371129 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2a0c5fceae78262c44cb522af38a925cc5919d3 Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: BarryTheBrowserTestBot <jdlrobson+ba...@gmail.com> Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org> Gerrit-Reviewer: Frankiebot <jdlrobson+fran...@gmail.com> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Phuedx <samsm...@wikimedia.org> Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
