jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/372340 )
Change subject: BSSkin: Fixed if statement for newer versions of echo
......................................................................
BSSkin: Fixed if statement for newer versions of echo
* in newer versions than 1.27 of echo, this text can be a message obect
Change-Id: I9cfbc0e9fa71187a7934bf022cb9906687d2eaeb
---
M includes/BlueSpiceSkinHooks.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Robert Vogel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/BlueSpiceSkinHooks.php b/includes/BlueSpiceSkinHooks.php
index 5c43323..0e43c9c 100644
--- a/includes/BlueSpiceSkinHooks.php
+++ b/includes/BlueSpiceSkinHooks.php
@@ -148,8 +148,10 @@
'class' => 'mw-echo-notification-badge-nojs
oo-ui-icon-bell oo-ui-widget-enabled mw-echo-notifications-badge',
) + $tpl->data['personal_urls']['notifications-alert'];
- if ( isset(
$tpl->data['personal_urls']['notifications-alert']['text'] )
- &&
$tpl->data['personal_urls']['notifications-alert']['text'] > 0 ) {
+ $bNotifications = !empty(
+
$tpl->data['personal_urls']['notifications-alert']['text']
+ );
+ if ( $bNotifications ) {
$tpl->data['bs_personal_info'][10]['active'] = true;
}
--
To view, visit https://gerrit.wikimedia.org/r/372340
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cfbc0e9fa71187a7934bf022cb9906687d2eaeb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/BlueSpiceSkin
Gerrit-Branch: master
Gerrit-Owner: Pwirth <[email protected]>
Gerrit-Reviewer: Dvogel hallowelt <[email protected]>
Gerrit-Reviewer: Ljonka <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
