Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372538 )
Change subject: Hygiene: Do not use numbered grays
......................................................................
Hygiene: Do not use numbered grays
We have names for a reason.
We should limit our use of the more ambiguious grays
Change-Id: I2c9d21ab0ec0bbbf02fa8767936401dbe9ec4177
---
M resources/mobile.categories.overlays/categories.less
M resources/mobile.editor.common/editor.less
M resources/mobile.gallery/gallery.less
M resources/mobile.issues/issues.less
M resources/mobile.languages.structured/LanguageOverlay.less
M resources/mobile.messageBox.styles/messageBox.less
M resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less
M resources/mobile.notifications.overlay/NotificationsOverlay.less
M resources/mobile.pagelist.styles/pagelist.less
M resources/mobile.pagesummary.styles/pagesummary.less
M resources/mobile.references/references.less
M resources/mobile.search/SearchOverlay.less
M resources/mobile.special.mobilediff.styles/mobilediff.less
M resources/mobile.special.pagefeed.styles/pagefeed.less
M resources/mobile.startup/Overlay.less
M skinStyles/mobile.editor.ve/minerva.less
16 files changed, 34 insertions(+), 34 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/38/372538/1
diff --git a/resources/mobile.categories.overlays/categories.less
b/resources/mobile.categories.overlays/categories.less
index 247e55f..ada7108 100644
--- a/resources/mobile.categories.overlays/categories.less
+++ b/resources/mobile.categories.overlays/categories.less
@@ -15,14 +15,14 @@
margin: 0 0 0 -1px;
border-width: 0 0 1px 1px;
border-style: solid;
- border-color: @colorGray12;
+ border-color: @grayLight;
padding: 5px 0 0;
line-height: 1.5;
text-align: center;
a {
display: block;
- color: @colorGray5;
+ color: @grayMediumDark;
margin: 0 1px 0 0;
border-bottom: 3px solid transparent;
}
diff --git a/resources/mobile.editor.common/editor.less
b/resources/mobile.editor.common/editor.less
index 264ac8d..451a28f 100644
--- a/resources/mobile.editor.common/editor.less
+++ b/resources/mobile.editor.common/editor.less
@@ -25,7 +25,7 @@
.message {
margin: 0 0 0.7em;
padding: 0 0 0.3em;
- border-bottom: 1px solid @colorGray12;
+ border-bottom: 1px solid @grayLight;
color: @infoColor;
p {
@@ -37,7 +37,7 @@
}
.editor-switcher {
- border-left: 1px solid @colorGray12;
+ border-left: 1px solid @grayLight;
.oo-ui-toolbar-bar {
font-size: unit( 0.8 * @targetIconSize / @baseIconSize,
em );
diff --git a/resources/mobile.gallery/gallery.less
b/resources/mobile.gallery/gallery.less
index a8fe481..6bf7453 100644
--- a/resources/mobile.gallery/gallery.less
+++ b/resources/mobile.gallery/gallery.less
@@ -9,7 +9,7 @@
padding-bottom: 20px;
p { // description
- color: @colorGray5;
+ color: @grayMediumDark;
line-height: 1.2;
}
}
diff --git a/resources/mobile.issues/issues.less
b/resources/mobile.issues/issues.less
index aa62e58..f0c8726 100644
--- a/resources/mobile.issues/issues.less
+++ b/resources/mobile.issues/issues.less
@@ -8,7 +8,7 @@
margin: 0;
padding: 0;
font-size: 0.8em;
- color: @colorGray7;
+ color: @grayMedium;
}
// overlay styles
diff --git a/resources/mobile.languages.structured/LanguageOverlay.less
b/resources/mobile.languages.structured/LanguageOverlay.less
index 506b2ed..c9af9ac 100644
--- a/resources/mobile.languages.structured/LanguageOverlay.less
+++ b/resources/mobile.languages.structured/LanguageOverlay.less
@@ -1,10 +1,10 @@
@import 'mobile.variables';
.language-overlay {
- background-color: @colorGray14;
+ background-color: @grayLightest;
.overlay-content {
- background-color: @colorGray14;
+ background-color: @grayLightest;
}
.panel {
@@ -41,7 +41,7 @@
}
a {
- border-top: solid 1px @colorGray14;
+ border-top: solid 1px @grayLightest;
cursor: pointer;
display: block;
padding: 0.75em 1em;
@@ -61,7 +61,7 @@
}
.title {
- color: @colorGray7;
+ color: @grayMedium;
padding-top: 0.5em;
}
}
diff --git a/resources/mobile.messageBox.styles/messageBox.less
b/resources/mobile.messageBox.styles/messageBox.less
index ef3c28f..e71fd11 100644
--- a/resources/mobile.messageBox.styles/messageBox.less
+++ b/resources/mobile.messageBox.styles/messageBox.less
@@ -6,9 +6,9 @@
// FIXME: standardise these two classes
.warningbox,
.mw-revision {
- border: 1px solid @colorGray12;
- background-color: @colorGray14;
- color: @colorGray2;
+ border: 1px solid @grayLight;
+ background-color: @grayLightest;
+ color: @grayDark;
}
.successbox {
diff --git
a/resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less
b/resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less
index 30f7bc2..1743e5e 100644
---
a/resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less
+++
b/resources/mobile.notifications.filter.overlay/NotificationsFilterOverlay.less
@@ -21,7 +21,7 @@
.mw-echo-ui-pageNotificationsOptionWidget {
.box-sizing( border-box );
- border: 1px solid @colorGray12;
+ border: 1px solid @grayLight;
padding: 0.7em 1.5em 1em 1em;
width: 100%;
}
@@ -31,7 +31,7 @@
}
.mw-echo-ui-crossWikiUnreadFilterWidget {
- border: 1px solid @colorGray12;
+ border: 1px solid @grayLight;
width: 100%;
margin-left: 0;
padding: 0;
diff --git a/resources/mobile.notifications.overlay/NotificationsOverlay.less
b/resources/mobile.notifications.overlay/NotificationsOverlay.less
index 81bdabb..943f869 100644
--- a/resources/mobile.notifications.overlay/NotificationsOverlay.less
+++ b/resources/mobile.notifications.overlay/NotificationsOverlay.less
@@ -27,7 +27,7 @@
padding: 0.5em;
font-size: 1.5em;
box-shadow: none;
- border: 1px solid @colorGray10;
+ border: 1px solid @grayMediumLight;
// Override the positioning of the menu
// so it is "stuck" on the bottom of the
// notification overlay panel
diff --git a/resources/mobile.pagelist.styles/pagelist.less
b/resources/mobile.pagelist.styles/pagelist.less
index c76bb48..9e8c12c 100644
--- a/resources/mobile.pagelist.styles/pagelist.less
+++ b/resources/mobile.pagelist.styles/pagelist.less
@@ -36,7 +36,7 @@
overflow: hidden;
li {
- color: @colorGray5;
+ color: @grayMediumDark;
position: relative;
border-bottom: 1px solid @grayLightest;
padding-top: @itemPaddingV;
@@ -62,13 +62,13 @@
> a {
display: block;
- color: @colorGray5;
+ color: @grayMediumDark;
&:active,
&:hover,
&:visited {
text-decoration: none;
- color: @colorGray5;
+ color: @grayMediumDark;
}
}
}
@@ -126,7 +126,7 @@
&.side-list .list-thumb {
padding-top: @itemPaddingV;
padding-bottom: @itemPaddingV;
- color: @colorGray2;
+ color: @grayDark;
p {
line-height: 1.2;
diff --git a/resources/mobile.pagesummary.styles/pagesummary.less
b/resources/mobile.pagesummary.styles/pagesummary.less
index 82d7700..937b7d0 100644
--- a/resources/mobile.pagesummary.styles/pagesummary.less
+++ b/resources/mobile.pagesummary.styles/pagesummary.less
@@ -23,7 +23,7 @@
font: inherit;
font-weight: bold;
// FIXME: Use one of the grays defined in variables.less
- color: @colorGray5;
+ color: @grayMediumDark;
a {
color: inherit;
}
diff --git a/resources/mobile.references/references.less
b/resources/mobile.references/references.less
index eb3a234..f3ccc72 100644
--- a/resources/mobile.references/references.less
+++ b/resources/mobile.references/references.less
@@ -10,7 +10,7 @@
.drawer.references {
background-color: @colorGray1;
- color: @colorGray12;
+ color: @grayLight;
max-height: 400px; // or half of window height, whichever is smaller
(see ReferencesDrawerBeta.js)
overflow-y: auto;
padding: @drawerPadding;
@@ -36,7 +36,7 @@
}
.text {
- color: @colorGray7;
+ color: @grayMedium;
cursor: default;
letter-spacing: 0.2em;
float: left;
diff --git a/resources/mobile.search/SearchOverlay.less
b/resources/mobile.search/SearchOverlay.less
index edda6d1..a28686a 100644
--- a/resources/mobile.search/SearchOverlay.less
+++ b/resources/mobile.search/SearchOverlay.less
@@ -116,7 +116,7 @@
.search-feedback {
box-shadow: 0 3px 3px 0 rgba( 117, 117, 117, 0.3 );
- border-top: 1px solid @colorGray12;
+ border-top: 1px solid @grayLight;
font-size: 0.8em;
padding: 0.5em 1em;
}
diff --git a/resources/mobile.special.mobilediff.styles/mobilediff.less
b/resources/mobile.special.mobilediff.styles/mobilediff.less
index 8072b76..1b0bfdf 100644
--- a/resources/mobile.special.mobilediff.styles/mobilediff.less
+++ b/resources/mobile.special.mobilediff.styles/mobilediff.less
@@ -29,7 +29,7 @@
}
.mw-mf-diff-date {
- color: @colorGray7;
+ color: @grayMedium;
}
// FIXME: Overly specific selector
@@ -83,7 +83,7 @@
height: @userInfoHeight;
padding: @userInfoPadding;
background-color: @colorGray15;
- border-top: solid 1px @colorGray12;
+ border-top: solid 1px @grayLight;
bottom: 0;
left: 0;
right: 0;
@@ -103,7 +103,7 @@
div {
text-align: center;
font-size: 1.85em;
- color: @colorGray7;
+ color: @grayMedium;
}
}
diff --git a/resources/mobile.special.pagefeed.styles/pagefeed.less
b/resources/mobile.special.pagefeed.styles/pagefeed.less
index 17d791f..ca2fce1 100644
--- a/resources/mobile.special.pagefeed.styles/pagefeed.less
+++ b/resources/mobile.special.pagefeed.styles/pagefeed.less
@@ -21,7 +21,7 @@
.page-header-bar {
li,
div {
- border-bottom: 1px solid @colorGray12;
+ border-bottom: 1px solid @grayLight;
padding: 5px 0 0;
line-height: 1.5;
text-align: center;
@@ -35,7 +35,7 @@
display: inline-block;
width: 25%;
margin: 0 0 0 -1px;
- border-left: 1px solid @colorGray12;
+ border-left: 1px solid @grayLight;
border-bottom: 0;
&:first-child {
@@ -45,7 +45,7 @@
/* stylelint-disable no-descending-specificity */
a {
display: block;
- color: @colorGray5;
+ color: @grayMediumDark;
margin: 0 1px 0 0;
border-bottom: 3px solid transparent;
}
@@ -62,7 +62,7 @@
// FIXME: Can we generalise these rules into a common design pattern?
.empty-page {
margin: 3em;
- color: @colorGray7;
+ color: @grayMedium;
text-align: center;
img {
width: 100%;
diff --git a/resources/mobile.startup/Overlay.less
b/resources/mobile.startup/Overlay.less
index 07a0a51..b24ebfe 100644
--- a/resources/mobile.startup/Overlay.less
+++ b/resources/mobile.startup/Overlay.less
@@ -144,7 +144,7 @@
// Only used on overlays in beta (nearby pages)- may not want to push
to stable
.content-header {
background-color: @colorGray15;
- border-bottom: 1px solid @colorGray14;
+ border-bottom: 1px solid @grayLightest;
padding-top: 20px;
padding-bottom: 20px;
line-height: inherit;
diff --git a/skinStyles/mobile.editor.ve/minerva.less
b/skinStyles/mobile.editor.ve/minerva.less
index 5e10e88..7818562 100644
--- a/skinStyles/mobile.editor.ve/minerva.less
+++ b/skinStyles/mobile.editor.ve/minerva.less
@@ -7,7 +7,7 @@
// heading styles to the header tags directly.
h1, h2 {
margin-bottom: 0.5em;
- border-bottom: solid 1px @colorGray14;
+ border-bottom: solid 1px @grayLightest;
overflow: hidden;
}
@@ -88,7 +88,7 @@
.ve-init-mw-mobileArticleTarget-toolbar {
@media all and ( min-width: @wgMFDeviceWidthDesktop ) {
- border-color: @colorGray12;
+ border-color: @grayLight;
border-style: solid;
border-width: 0 1px;
}
--
To view, visit https://gerrit.wikimedia.org/r/372538
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c9d21ab0ec0bbbf02fa8767936401dbe9ec4177
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
