jenkins-bot has submitted this change and it was merged.
Change subject: Show message documentation to anon users
......................................................................
Show message documentation to anon users
This was caused by the unexpected behavior of
$foo.append( undefined, $bar ); which did not append anything.
Arguably this is not wrong, since the documentation says that
it takes string, DOM and jQuery objects - still don't like it.
Took the easy way out by just hiding control buttons while
keeping the DOM structure the same.
Bug: 46159
Change-Id: If5dd662fd29d3dc63a4a49998dd698e448fbd8c6
---
M resources/js/ext.translate.editor.js
1 file changed, 34 insertions(+), 32 deletions(-)
Approvals:
Amire80: Looks good to me, but someone else must approve
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index f82300c..9117353 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -554,40 +554,38 @@
);
if ( mw.config.get(
'wgTranslateDocumentationLanguageCode' ) ) {
- if ( mw.translate.canTranslate() ) {
- $messageDescSaveButton = $( '<button>' )
- .addClass( 'blue button
tux-editor-savedoc-button' )
- .prop( 'disabled', true )
- .text( mw.msg(
'tux-editor-doc-editor-save' ) )
- .on( 'click', function () {
-
translateEditor.saveDocumentation();
- } );
+ $messageDescSaveButton = $( '<button>' )
+ .addClass( 'blue button
tux-editor-savedoc-button' )
+ .prop( 'disabled', true )
+ .text( mw.msg(
'tux-editor-doc-editor-save' ) )
+ .on( 'click', function () {
+
translateEditor.saveDocumentation();
+ } );
- $messageDescCancelButton = $(
'<button>' )
- .addClass( 'button
tux-editor-skipdoc-button' )
- .text( mw.msg(
'tux-editor-doc-editor-cancel' ) )
- .on( 'click', function () {
-
translateEditor.hideDocumentationEditor();
- } );
+ $messageDescCancelButton = $( '<button>' )
+ .addClass( 'button
tux-editor-skipdoc-button' )
+ .text( mw.msg(
'tux-editor-doc-editor-cancel' ) )
+ .on( 'click', function () {
+
translateEditor.hideDocumentationEditor();
+ } );
- $messageDescEditor = $( '<div>' )
- .addClass( 'row
message-desc-editor hide' )
- .append(
- $( '<textarea>' )
- .attr( {
-
placeholder: mw.msg( 'tux-editor-doc-editor-placeholder' )
- } )
- .on( 'input
propertychange', function () {
-
$messageDescSaveButton.prop( 'disabled', false );
- } ),
- $( '<div>' )
- .addClass(
'row' )
- .append(
-
$messageDescSaveButton,
-
$messageDescCancelButton
- )
- );
- }
+ $messageDescEditor = $( '<div>' )
+ .addClass( 'row message-desc-editor
hide' )
+ .append(
+ $( '<textarea>' )
+ .attr( {
+ placeholder:
mw.msg( 'tux-editor-doc-editor-placeholder' )
+ } )
+ .on( 'input
propertychange', function () {
+
$messageDescSaveButton.prop( 'disabled', false );
+ } ),
+ $( '<div>' )
+ .addClass( 'row' )
+ .append(
+
$messageDescSaveButton,
+
$messageDescCancelButton
+ )
+ );
$messageDescViewer = $( '<div>' )
.addClass( 'message-desc-viewer hide' )
@@ -608,6 +606,10 @@
)
);
+ if ( !mw.translate.canTranslate() ) {
+ $messageDescViewer.find(
'.message-desc-control' ).addClass( 'hide' );
+ }
+
$infoColumn.append(
$messageDescEditor,
$messageDescViewer
--
To view, visit https://gerrit.wikimedia.org/r/54211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5dd662fd29d3dc63a4a49998dd698e448fbd8c6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
