WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372851 )
Change subject: Remove unneeded when() from LemmaWidget tests
......................................................................
Remove unneeded when() from LemmaWidget tests
Change-Id: I0f7a2e944984b47dbc3636eef34909ff036cf308
---
M tests/jasmine/LemmaWidget.spec.js
1 file changed, 16 insertions(+), 21 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/51/372851/1
diff --git a/tests/jasmine/LemmaWidget.spec.js
b/tests/jasmine/LemmaWidget.spec.js
index d52c4cd..c368f18 100644
--- a/tests/jasmine/LemmaWidget.spec.js
+++ b/tests/jasmine/LemmaWidget.spec.js
@@ -17,18 +17,18 @@
it( 'initialize widget with one lemma', function () {
var widget = newWidget( [ new Lemma( 'hello', 'en' ) ] );
- assertWidget( widget ).when( 'created' ).dom.containsLemma(
'hello', 'en' );
+ assertWidget( widget ).dom.containsLemma( 'hello', 'en' );
} );
it( 'switch to edit mode', function ( done ) {
var widget = newWidget( [ new Lemma( 'hello', 'en' ) ] );
- assertWidget( widget ).when( 'created' ).dom.hasNoInputFields();
+ assertWidget( widget ).dom.hasNoInputFields();
widget.edit();
widget.$nextTick( function () {
- assertWidget( widget ).when( 'switched to edit mode'
).isInEditMode();
- assertWidget( widget ).when( 'switched to edit mode'
).dom.hasAtLeastOneInputField();
+ assertWidget( widget ).isInEditMode();
+ assertWidget( widget ).dom.hasAtLeastOneInputField();
done();
} );
} );
@@ -39,7 +39,7 @@
widget.edit();
widget.cancel();
widget.$nextTick( function () {
- assertWidget( widget ).when( 'canceled the edit mode'
).dom.hasNoInputFields();
+ assertWidget( widget ).dom.hasNoInputFields();
done();
} );
} );
@@ -47,11 +47,11 @@
it( 'add a new lemma', function ( done ) {
var widget = newWidget( [ new Lemma( 'hello', 'en' ) ] );
- assertWidget( widget ).when( 'created' ).dom.containsLemma(
'hello', 'en' );
+ assertWidget( widget ).dom.containsLemma( 'hello', 'en' );
widget.add();
widget.$nextTick( function () {
- assertWidget( widget ).when( 'addition triggered'
).dom.containsLemma( 'hello', 'en' );
- assertWidget( widget ).when( 'addition triggered'
).dom.containsLemma( '', '' );
+ assertWidget( widget ).dom.containsLemma( 'hello', 'en'
);
+ assertWidget( widget ).dom.containsLemma( '', '' );
done();
} );
} );
@@ -60,10 +60,10 @@
var lemmaToRemove = new Lemma( 'hello', 'en' ),
widget = newWidget( [ lemmaToRemove ] );
- assertWidget( widget ).when( 'created' ).dom.containsLemma(
'hello', 'en' );
+ assertWidget( widget ).dom.containsLemma( 'hello', 'en' );
widget.remove( lemmaToRemove );
widget.$nextTick( function () {
- assertWidget( widget ).when( 'lemma removed'
).dom.containsNoLemmas();
+ assertWidget( widget ).dom.containsNoLemmas();
done();
} );
} );
@@ -80,7 +80,7 @@
widget.save().then( function () {
expect( storeSpy.called, 'to be true' );
expect( storeSpy.calledWith( 'save', lemmas ), 'to be
true' );
- assertWidget( widget ).when( 'saved'
).isNotInEditMode();
+ assertWidget( widget ).isNotInEditMode();
done();
} );
} );
@@ -100,12 +100,11 @@
}
function assertWidget( widget ) {
- var when = '',
- selector = {
- lemma: '.lemma-widget_lemma',
- lemmaValue: '.lemma-widget_lemma-value',
- lemmaLanguage: '.lemma-widget_lemma-language'
- };
+ var selector = {
+ lemma: '.lemma-widget_lemma',
+ lemmaValue: '.lemma-widget_lemma-value',
+ lemmaLanguage: '.lemma-widget_lemma-language'
+ };
return {
isInEditMode: function () {
@@ -113,10 +112,6 @@
},
isNotInEditMode: function () {
expect( widget.inEditMode, 'to be false' );
- },
- when: function ( text ) {
- when = 'when ' + text + ': ';
- return this;
},
dom: {
hasNoInputFields: function () {
--
To view, visit https://gerrit.wikimedia.org/r/372851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f7a2e944984b47dbc3636eef34909ff036cf308
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
