jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/372588 )
Change subject: RCFilters: Add title attribute to [x] button
......................................................................
RCFilters: Add title attribute to [x] button
For accessibility, add title attribute to the remove button in
the active filters area.
Bug: T173608
Change-Id: Idcf735e3b610345a8206f83fe5f8115900455cc2
---
M languages/i18n/en.json
M languages/i18n/qqq.json
M resources/Resources.php
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
4 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Sbisson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 6126bbd..6078b64 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1350,6 +1350,7 @@
"recentchanges-legend-unpatrolled":
"{{int:recentchanges-label-unpatrolled}}",
"recentchanges-legend-plusminus": "(<em>±123</em>)",
"recentchanges-submit": "Show",
+ "rcfilters-tag-remove": "Remove '$1'",
"rcfilters-legend-heading": "<strong>List of abbreviations:</strong>",
"rcfilters-other-review-tools": "<strong>Other review tools</strong>",
"rcfilters-group-results-by-page": "Group results by page",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index bc0fe2c..1bcb075 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1540,6 +1540,7 @@
"recentchanges-legend-unpatrolled": "Used as legend on
[[Special:RecentChanges]] and [[Special:Watchlist]].\n\nRefers to
{{msg-mw|Recentchanges-label-unpatrolled}}.",
"recentchanges-legend-plusminus": "{{optional}}\nA plus/minus sign with
a number for the legend.",
"recentchanges-submit": "Label for submit button in
[[Special:RecentChanges]]\n{{Identical|Show}}",
+ "rcfilters-tag-remove": "A tooltip for the button that removes a filter
from the active filters area in [[Special:RecentChanges]] and
[[Special:Watchlist]] when RCFilters are enabled. \n\nParameters: $1 - Tag
label",
"rcfilters-legend-heading": "Used as a heading for legend box on
[[Special:RecentChanges]] and [[Special:Watchlist]] when RCFilters are
enabled.",
"rcfilters-other-review-tools": "Used as a heading for the community
collection of other links on [[Special:RecentChanges]] when RCFilters are
enabled.",
"rcfilters-group-results-by-page": "A label for the checkbox describing
whether the results in [[Special:RecentChanges]] are grouped by page when
RCFilters are enabled.",
diff --git a/resources/Resources.php b/resources/Resources.php
index c0c5d9e..6be211e 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1832,6 +1832,7 @@
],
],
'messages' => [
+ 'rcfilters-tag-remove',
'rcfilters-activefilters',
'rcfilters-advancedfilters',
'rcfilters-group-results-by-page',
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
index bf75149..81889b2 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
@@ -48,6 +48,9 @@
this.$highlight = $( '<div>' )
.addClass( 'mw-rcfilters-ui-tagItemWidget-highlight' );
+ // Add title attribute with the item label to 'x' button
+ this.closeButton.setTitle( mw.msg( 'rcfilters-tag-remove',
this.model.getLabel() ) );
+
// Events
this.model.connect( this, { update: 'onModelUpdate' } );
--
To view, visit https://gerrit.wikimedia.org/r/372588
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcf735e3b610345a8206f83fe5f8115900455cc2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: Sbisson <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: TTO <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
