jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372865 )

Change subject: Fix 'unread' dot top padding regression
......................................................................


Fix 'unread' dot top padding regression

All frameless buttons seemed to have recieved a generous padding-top
in the latest OOUI release. This fix overrides that.

Bug: T173059
Change-Id: Ia1f1bbc48410555163afabc84a199e7a69bb95dc
---
M modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Sbisson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less 
b/modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less
index 5c99044..ecee641 100644
--- a/modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less
+++ b/modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less
@@ -22,6 +22,11 @@
                }
        }
 
+       // Override OOUI specific rule for frameless buttons that adds a ~2.5em 
padding-top
+       
&.oo-ui-widget.oo-ui-widget-enabled.oo-ui-buttonElement.oo-ui-buttonElement-frameless
 > .oo-ui-buttonElement-button {
+               padding-top: 0;
+       }
+
        &:hover .mw-echo-ui-toggleReadCircleButtonWidget-circle {
                // Mark as read
                background-color: #447ff5;

-- 
To view, visit https://gerrit.wikimedia.org/r/372865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1f1bbc48410555163afabc84a199e7a69bb95dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Sbisson <sbis...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to