jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/372893 )
Change subject: Use namespaced ScopedCallback
......................................................................
Use namespaced ScopedCallback
The non-namespaced version is deprecated since 1.28
Change-Id: Icb3fed78882913a26aad4bdb1a84cb5a3e8ca6bb
---
M engines/LuaCommon/LuaCommon.php
M tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index 33f8b37..954c60d 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -1,5 +1,7 @@
<?php
+use Wikimedia\ScopedCallback;
+
// @codingStandardsIgnoreLine Squiz.Classes.ValidClassName.NotCamelCaps
abstract class Scribunto_LuaEngine extends ScribuntoEngineBase {
/**
diff --git a/tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
b/tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
index cbc3955..fbead43 100644
--- a/tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
+++ b/tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
@@ -1,5 +1,7 @@
<?php
+use Wikimedia\ScopedCallback;
+
// @codingStandardsIgnoreLine Squiz.Classes.ValidClassName.NotCamelCaps
class Scribunto_LuaUstringLibraryTests extends Scribunto_LuaEngineTestBase {
protected static $moduleName = 'UstringLibraryTests';
--
To view, visit https://gerrit.wikimedia.org/r/372893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb3fed78882913a26aad4bdb1a84cb5a3e8ca6bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
