Kaldari has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372908 )
Change subject: Keep workflow config conditions simple for now
......................................................................
Keep workflow config conditions simple for now
Let's not add any unneeded features until we actually need them.
This removes the check for redirectRight, which doesn't currently
have a use case. Also tweaked the wording of the comments to make
it slightly more clear.
Change-Id: Ic1ead74c4c5d06adf557296c8ce3ce9ce99ccbe7
---
M includes/Workflow.php
1 file changed, 2 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleCreationWorkflow
refs/changes/08/372908/1
diff --git a/includes/Workflow.php b/includes/Workflow.php
index 2680efe..72ef235 100644
--- a/includes/Workflow.php
+++ b/includes/Workflow.php
@@ -60,17 +60,13 @@
}
foreach ( $conditions as $cond ) {
+
// Filter on namespace
if ( !in_array( $title->getNamespace(),
$cond['namespaces'] ) ) {
continue;
}
- // Filter out users who don't have these rights
- if ( isset( $cond['redirectRight'] ) &&
!$user->isAllowed( $cond['redirectRight'] ) ) {
- continue;
- }
-
- // Filter out people who have these rights
+ // Don't intercept users that have these rights
if ( isset( $cond['excludeRight'] ) &&
$user->isAllowed( $cond['excludeRight'] ) ) {
continue;
}
--
To view, visit https://gerrit.wikimedia.org/r/372908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1ead74c4c5d06adf557296c8ce3ce9ce99ccbe7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
