ItSpiderman has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373036 )
Change subject: Fix for hook handler param
......................................................................
Fix for hook handler param
PageForms call this hook with PFUploadWindow instead of SpecialUpload
I see type of param already commented out to fix this, but as on our
internal wiki i fixed it by replacing SpecialUpload with common root class
for both, SpecialP
Change-Id: Iac0f6763000a502cf821ed8d67d07658908c9084
ERM: #7253
---
M src/Hooks/UploadFormBeforeProcessing.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NSFileRepo
refs/changes/36/373036/1
diff --git a/src/Hooks/UploadFormBeforeProcessing.php
b/src/Hooks/UploadFormBeforeProcessing.php
index 1a3c408..cab7ab5 100644
--- a/src/Hooks/UploadFormBeforeProcessing.php
+++ b/src/Hooks/UploadFormBeforeProcessing.php
@@ -24,7 +24,7 @@
/**
* Check for Namespace in Title line
- * @param SpecialUpload $uploadForm
+ * @param SpecialPage $uploadForm
* @return boolean
*/
public static function handle( &$uploadForm ) {
@@ -41,9 +41,9 @@
* See static method "handle"
* @param \IContextSource $context
* @param \Config $config
- * @param \SpecialUpload $uploadForm 'Extension:PageForms' fires this
hook with \PFUploadWindow as parameter
+ * @param \SpecialPage $uploadForm 'Extension:PageForms' fires this
hook with \PFUploadWindow as parameter
*/
- public function __construct( \IContextSource $context, \Config $config,
/* \SpecialUpload */ $uploadForm ) {
+ public function __construct( \IContextSource $context, \Config $config,
\SpecialPage $uploadForm ) {
$this->context = $context;
$this->config = $config;
$this->uploadForm = $uploadForm;
--
To view, visit https://gerrit.wikimedia.org/r/373036
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac0f6763000a502cf821ed8d67d07658908c9084
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NSFileRepo
Gerrit-Branch: master
Gerrit-Owner: ItSpiderman <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
