Foxy brown has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373047 )
Change subject: Adding the correct use in the DateTimeInputWidget text
placeholder
......................................................................
Adding the correct use in the DateTimeInputWidget text placeholder
Change-Id: Ic73cf7b3d7c96bcf80a82da70ee2e1e1c515f2d8
Depends-On: Ic475ae9e80e353b7f042ed36c77fd47703301de4
---
M modules/articleReminder/style/mw.articleReminder.ui.ArticleReminderWidget.less
M modules/articleReminder/ui/mw.articleReminder.ui.ArticleReminderWidget.js
2 files changed, 1 insertion(+), 21 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/47/373047/1
diff --git
a/modules/articleReminder/style/mw.articleReminder.ui.ArticleReminderWidget.less
b/modules/articleReminder/style/mw.articleReminder.ui.ArticleReminderWidget.less
index 4b0f75a..74664fc 100644
---
a/modules/articleReminder/style/mw.articleReminder.ui.ArticleReminderWidget.less
+++
b/modules/articleReminder/style/mw.articleReminder.ui.ArticleReminderWidget.less
@@ -11,17 +11,4 @@
&-ok {
float: right;
}
-
- // This one for the text placeholder into a timestamp input HACK
-
.mw-widgets-datetime-dateTimeInputWidget-empty.mw-widgets-datetime-dateTimeInputWidget
{
- // This one is to hide but still getting DOM events
- .mw-widgets-datetime-dateTimeInputWidget-field {
- opacity: 0;
- }
-
.mw-widgets-datetime-dateTimeInputWidget-fields[data-placeholder]:not(:focus):before
{
- content: attr( data-placeholder );
- float: left;
- margin-left: 2px;
- }
- }
}
diff --git
a/modules/articleReminder/ui/mw.articleReminder.ui.ArticleReminderWidget.js
b/modules/articleReminder/ui/mw.articleReminder.ui.ArticleReminderWidget.js
index 594c8a2..4d02e5c 100644
--- a/modules/articleReminder/ui/mw.articleReminder.ui.ArticleReminderWidget.js
+++ b/modules/articleReminder/ui/mw.articleReminder.ui.ArticleReminderWidget.js
@@ -55,13 +55,6 @@
/* Methods */
- mw.articleReminder.ui.ArticleReminderWidget.prototype.onToggle =
function ( isVisible ) {
- if ( isVisible ) {
- // TEMP: till we'll find a solution for
dateTimeInputWidget text placeholder
- $( '.mw-widgets-datetime-dateTimeInputWidget-fields'
).attr( 'data-placeholder', mw.msg( 'echo-reminder-timestamp-input-placeholder'
) );
- }
- };
-
/**
* Creates the UI content if there is no exists reminder
*
@@ -89,6 +82,7 @@
formatter: {
format:
'${year|0}-${month|0}-${day|0}T${hour|0}:${minute|0}:${second|0}'
},
+ placeholder: mw.msg(
'echo-reminder-timestamp-input-placeholder' ),
min: new Date()
} );
@@ -124,7 +118,6 @@
);
// Events
- this.connect( this, { toggle: 'onToggle' } );
this.timestampOptionsGroupWidget.aggregate( { click:
'timestampOptionChoosen' } );
this.timestampOptionsGroupWidget.connect( this, {
timestampOptionChoosen: 'onTimestampOptionChosen' } );
this.timestampInput.connect( this, { change:
'onTimestampInputChange' } );
--
To view, visit https://gerrit.wikimedia.org/r/373047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic73cf7b3d7c96bcf80a82da70ee2e1e1c515f2d8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Foxy brown <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
