Santhosh has submitted this change and it was merged.

Change subject: (bug 45725) Fix switching to Page mode
......................................................................


(bug 45725) Fix switching to Page mode

The changes needed for switching to the Page and the List view are
the same and different from the proofread view. Changed the filter
accordingly.

Change-Id: I202b04e6f30f3b5d58fdefeea5dac0f4af5fda10
---
M resources/js/ext.translate.messagetable.js
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Santhosh: Verified; Looks good to me, approved



diff --git a/resources/js/ext.translate.messagetable.js 
b/resources/js/ext.translate.messagetable.js
index 1435b0d..a14a36b 100644
--- a/resources/js/ext.translate.messagetable.js
+++ b/resources/js/ext.translate.messagetable.js
@@ -531,9 +531,10 @@
                        $controlOwnButton = messageTable.$actionBar.find( 
'.tux-proofread-own-translations-button' );
                        $hideTranslatedButton = messageTable.$actionBar.find( 
'.tux-editor-clear-translated' );
 
-                       if ( messageTable.mode === 'proofread' || 
messageTable.mode === 'page' ) {
+                       if ( messageTable.mode === 'proofread' ) {
                                $tuxTabUntranslated.addClass( 'hide' );
                                $tuxTabUnproofread.removeClass( 'hide' );
+
                                // Fix the filter if it is untranslated. 
Untranslated does not make sense
                                // for proofread mode. Keep the filter if it is 
not 'untranslated'
                                if ( !filter || filter.indexOf( '!translated' ) 
>= 0 )  {
@@ -543,7 +544,7 @@
                                                + '|!last-translator:' + userId 
);
                                        $tuxTabUnproofread.addClass( 'selected' 
);
                                }
-                               $tuxTabUntranslated.addClass( 'hide' );
+
                                $controlOwnButton.removeClass( 'hide' );
                                $hideTranslatedButton.addClass( 'hide' );
                        } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/54213
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I202b04e6f30f3b5d58fdefeea5dac0f4af5fda10
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Pginer <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to