jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/373085 )
Change subject: QA: Do not run various toast notification browser tests on BC
......................................................................
QA: Do not run various toast notification browser tests on BC
These flake too much. We have coverage in @firefox or @integration
so let's remove these test runs from the beta cluster job.
All tests will run somewhere.
Bug: T170890
Change-Id: I269991a22ab5a2b54aed8ad453013bb9be648502
---
M tests/browser/features/editor_wikitext_saving.feature
M tests/browser/features/language.feature
2 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/tests/browser/features/editor_wikitext_saving.feature
b/tests/browser/features/editor_wikitext_saving.feature
index cc4cf16..07b9517 100644
--- a/tests/browser/features/editor_wikitext_saving.feature
+++ b/tests/browser/features/editor_wikitext_saving.feature
@@ -4,7 +4,7 @@
Background:
Given I am logged into the mobile website
- @smoke @editing @integration @chrome
+ @smoke @editing @integration
Scenario: Successful edit on page without languages shows no language button
[bug 63675]
Given the page "Selenium no languages test page" exists
When I click the edit button
diff --git a/tests/browser/features/language.feature
b/tests/browser/features/language.feature
index f45a064..d17d090 100644
--- a/tests/browser/features/language.feature
+++ b/tests/browser/features/language.feature
@@ -4,31 +4,35 @@
Background:
Given I am using the mobile site
- @smoke @integration
+ @smoke @integration @en.m.wikipedia.beta.wmflabs.org
Scenario: Language button
Given I go to a page that has languages
Then I should see the switch-language page action
- @smoke @integration
+ @smoke @integration @en.m.wikipedia.beta.wmflabs.org
Scenario: Language button (on a page that doesn't have languages)
Given I go to a page that does not have languages
Then I should see the disabled switch-language page action
+ @en.m.wikipedia.beta.wmflabs.org
Scenario: Tapping icon opens language overlay
Given I go to a page that has languages
When I click the switch-language page action
Then I should see the language overlay
+ @en.m.wikipedia.beta.wmflabs.org
Scenario: Tapping icon does not open language overlay (on a page that
doesn't have languages)
Given I go to a page that does not have languages
When I click the switch-language page action
Then I should not see the languages overlay
+ @integration
Scenario: Tapping the disabled icon shows a toast
Given I go to a page that does not have languages
When I click the switch-language page action
Then I should see a toast with message "This page is not available in
other languages."
+ @en.m.wikipedia.beta.wmflabs.org
Scenario: Closing language overlay (overlay button)
Given I go to a page that has languages
When I click the switch-language page action
@@ -36,6 +40,7 @@
And I click the language overlay close button
Then I should not see the languages overlay
+ @en.m.wikipedia.beta.wmflabs.org
Scenario: Closing language overlay (browser button)
Given I go to a page that has languages
When I click the switch-language page action
@@ -43,6 +48,7 @@
And I click the browser back button
Then I should not see the languages overlay
+ @en.m.wikipedia.beta.wmflabs.org
Scenario: Checking that there are no suggested language links
Given I go to a page that has languages
When I click the switch-language page action
@@ -50,7 +56,7 @@
Then I should not see a suggested language link
Then I should see a non-suggested language link
- @smoke
+ @smoke @en.m.wikipedia.beta.wmflabs.org @integration
Scenario: Checking that the suggested language link has been created
Given I go to a page that has languages
And I click the switch-language page action
--
To view, visit https://gerrit.wikimedia.org/r/373085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I269991a22ab5a2b54aed8ad453013bb9be648502
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
