jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/373101 )
Change subject: WX parser: set gateway_txn_id on refunds
......................................................................
WX parser: set gateway_txn_id on refunds
Note that it's the same as the parent id. Unhelpful, but that's how
we've been doing things.
Bug: T173457
Change-Id: I3d57121f02e47b68a3c4eb0e521ec3aa189c8ff6
---
M PaymentProviders/Ingenico/Audit/IngenicoAudit.php
M PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
2 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Mepps: Looks good to me, approved
jenkins-bot: Verified
diff --git a/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
b/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
index 2de3b84..5d03343 100644
--- a/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
+++ b/PaymentProviders/Ingenico/Audit/IngenicoAudit.php
@@ -120,6 +120,9 @@
protected function parseRefund( DOMElement $recordNode, $type ) {
$record = $this->xmlToArray( $recordNode, $this->refundMap );
$record['type'] = $type;
+ // FIXME: Transaction ID is the same as the parent transaction
ID.
+ // That's not helpful...
+ $record['gateway_txn_id'] = $record['gateway_parent_id'];
if ( $record['installment'] < 0 ) {
// Refunds have negative EffortID. Weird.
// TODO: for refunds of recurring payments, determine
whether the
diff --git a/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
b/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
index 5b68013..428dff5 100644
--- a/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
+++ b/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php
@@ -85,6 +85,7 @@
'date' => 1500942220,
'gross' => 100,
'gateway_parent_id' => '123456789',
+ 'gateway_txn_id' => '123456789',
'installment' => 1,
'gross_currency' => 'USD',
'type' => 'refund',
@@ -106,6 +107,7 @@
'date' => 1495023569,
'gross' => 200,
'gateway_parent_id' => '5167046621',
+ 'gateway_txn_id' => '5167046621',
'installment' => 1,
'gross_currency' => 'USD',
'type' => 'chargeback',
--
To view, visit https://gerrit.wikimedia.org/r/373101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d57121f02e47b68a3c4eb0e521ec3aa189c8ff6
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Mepps <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
