jenkins-bot has submitted this change and it was merged.
Change subject: Some bandage to avoid fatal errors in non-TUX
......................................................................
Some bandage to avoid fatal errors in non-TUX
Bug: 44137
Change-Id: If4f11abcf4c571b43be901b801321e7a032a4b63
---
M utils/TranslationEditPage.php
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/utils/TranslationEditPage.php b/utils/TranslationEditPage.php
index ff52e9a..8a3b029 100644
--- a/utils/TranslationEditPage.php
+++ b/utils/TranslationEditPage.php
@@ -86,7 +86,14 @@
return;
}
- $translation = $helpers->getTranslation();
+ $handle = new MessageHandle( $this->getTitle() );
+ $groupId = MessageIndex::getPrimaryGroupId( $handle );
+
+ $translatio = '';
+ if ( $groupId ) {
+ $translation = $helpers->getTranslation();
+ }
+
$targetLang = Language::factory( $helpers->getTargetLanguage()
);
$textareaParams = array(
'name' => 'text',
@@ -98,7 +105,7 @@
'dir' => $targetLang->getDir(),
);
- if ( !$wgUser->isAllowed( 'translate' ) ) {
+ if ( $groupId || !$wgUser->isAllowed( 'translate' ) ) {
$textareaParams['readonly'] = 'readonly';
}
--
To view, visit https://gerrit.wikimedia.org/r/54335
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4f11abcf4c571b43be901b801321e7a032a4b63
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
